From: Jens Axboe <[email protected]>
To: [email protected], [email protected]
Subject: Re: [PATCH v2] io_uring: fix leaks on IOPOLL and CQE_SKIP
Date: Sun, 17 Apr 2022 06:54:31 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <5072fc8693fbfd595f89e5d4305bfcfd5d2f0a64.1650186611.git.asml.silence@gmail.com>
On Sun, 17 Apr 2022 10:10:34 +0100, Pavel Begunkov wrote:
> If all completed requests in io_do_iopoll() were marked with
> REQ_F_CQE_SKIP, we'll not only skip CQE posting but also
> io_free_batch_list() leaking memory and resources.
>
> Move @nr_events increment before REQ_F_CQE_SKIP check. We'll potentially
> return the value greater than the real one, but iopolling will deal with
> it and the userspace will re-iopoll if needed. In anyway, I don't think
> there are many use cases for REQ_F_CQE_SKIP + IOPOLL.
>
> [...]
Applied, thanks!
[1/1] io_uring: fix leaks on IOPOLL and CQE_SKIP
commit: c0713540f6d55c53dca65baaead55a5a8b20552d
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2022-04-17 12:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-17 9:10 [PATCH v2] io_uring: fix leaks on IOPOLL and CQE_SKIP Pavel Begunkov
2022-04-17 12:54 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165020007118.8177.8238194933142878483.b4-ty@kernel.dk \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox