From: Jens Axboe <[email protected]>
To: [email protected], [email protected]
Subject: Re: [PATCH 5.19] io_uring: fix req->apoll_events
Date: Tue, 21 Jun 2022 07:49:26 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <0aef40399ba75b1a4d2c2e85e6e8fd93c02fc6e4.1655814213.git.asml.silence@gmail.com>
On Tue, 21 Jun 2022 13:25:06 +0100, Pavel Begunkov wrote:
> apoll_events should be set once in the beginning of poll arming just as
> poll->events and not change after. However, currently io_uring resets it
> on each __io_poll_execute() for no clear reason. There is also a place
> in __io_arm_poll_handler() where we add EPOLLONESHOT to downgrade a
> multishot, but forget to do the same thing with ->apoll_events, which is
> buggy.
>
> [...]
Applied, thanks!
[1/1] io_uring: fix req->apoll_events
commit: aacf2f9f382c91df73f33317e28a4c34c8038986
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2022-06-21 13:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 12:25 [PATCH 5.19] io_uring: fix req->apoll_events Pavel Begunkov
2022-06-21 12:28 ` Pavel Begunkov
2022-06-21 13:28 ` Hao Xu
2022-06-21 13:49 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165581936663.2557468.6879052235467138335.b4-ty@kernel.dk \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox