From: Jens Axboe <[email protected]>
To: Pavel Begunkov <[email protected]>, [email protected]
Cc: [email protected]
Subject: Re: [PATCH 5.15] io_uring: don't forget to clear REQ_F_ARM_LTIMEOUT
Date: Mon, 16 Aug 2021 12:49:05 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <614f650abdd5fee97aa5a6a87028a2c47d2a6c94.1629137586.git.asml.silence@gmail.com>
On 8/16/21 12:16 PM, Pavel Begunkov wrote:
> Even though it should be safe to poke into req->link after
> io_issue_sqe() in terms of races, it may end up retiring a request, e.g.
> when someone calls io_req_complete(). It'll be placed into an internal
> request cache, so the memory would be valid with other guarantees, but
> the request will be actually dismantled and with requests linked removed
> and enqueued.
>
> Hence, don't forget to remove REQ_F_ARM_LTIMEOUT after a linked timeout
> got disarmed, otherwise following io_prep_linked_timeout() will expect
> req->link to be not-zero and so fault.
Since its tip of tree, I will just fold this one in.
--
Jens Axboe
next prev parent reply other threads:[~2021-08-16 18:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 18:16 [PATCH 5.15] io_uring: don't forget to clear REQ_F_ARM_LTIMEOUT Pavel Begunkov
2021-08-16 18:49 ` Jens Axboe [this message]
2021-08-16 22:51 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox