* [patch] liburing: fix return code for test/hardlink.t
@ 2022-08-26 17:34 Jeff Moyer
2022-08-26 18:42 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Moyer @ 2022-08-26 17:34 UTC (permalink / raw)
To: io-uring, axboe; +Cc: eschwartz93
Hi,
Commit a68c88a093719 ("tests: mark passing tests which exit early as
skipped") changed the return code for this test from success to skip for
the case where the test successfully runs to completion. Fix it.
Signed-off-by: Jeff Moyer <[email protected]>
diff --git a/test/hardlink.c b/test/hardlink.c
index 29395c3..aeb9ac6 100644
--- a/test/hardlink.c
+++ b/test/hardlink.c
@@ -124,7 +124,7 @@ int main(int argc, char *argv[])
unlinkat(AT_FDCWD, linkname, 0);
unlinkat(AT_FDCWD, target, 0);
io_uring_queue_exit(&ring);
- return T_EXIT_SKIP;
+ return T_EXIT_PASS;
skip:
unlinkat(AT_FDCWD, linkname, 0);
unlinkat(AT_FDCWD, target, 0);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] liburing: fix return code for test/hardlink.t
2022-08-26 17:34 [patch] liburing: fix return code for test/hardlink.t Jeff Moyer
@ 2022-08-26 18:42 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2022-08-26 18:42 UTC (permalink / raw)
To: io-uring, Jeff Moyer; +Cc: eschwartz93
On Fri, 26 Aug 2022 13:34:59 -0400, Jeff Moyer wrote:
> Commit a68c88a093719 ("tests: mark passing tests which exit early as
> skipped") changed the return code for this test from success to skip for
> the case where the test successfully runs to completion. Fix it.
>
>
Applied, thanks!
[1/1] liburing: fix return code for test/hardlink.t
commit: 8af924d6d3ac6a92c4af1df847cf713e4d2b67e3
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-26 18:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-26 17:34 [patch] liburing: fix return code for test/hardlink.t Jeff Moyer
2022-08-26 18:42 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox