* [PATCH liburing v1 1/3] github bot: Upgrade clang version to 16
2022-08-31 0:48 [PATCH liburing v1 0/3] liburing updates Ammar Faizi
@ 2022-08-31 0:48 ` Ammar Faizi
2022-08-31 0:48 ` [PATCH liburing v1 2/3] CHANGELOG: Note about `io_uring_{enter,enter2,register,setup}` Ammar Faizi
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Ammar Faizi @ 2022-08-31 0:48 UTC (permalink / raw)
To: Jens Axboe
Cc: Ammar Faizi, Muhammad Rizki, Kanna Scarlet, io-uring Mailing List,
Linux Kernel Mailing List, GNU/Weeb Mailing List
From: Ammar Faizi <[email protected]>
clang-16 is now available, use it.
Signed-off-by: Ammar Faizi <[email protected]>
---
.github/workflows/build.yml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 333929c..2608644 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -91,15 +91,15 @@ jobs:
uses: actions/checkout@v2
- name: Install Compilers
run: |
if [[ "${{matrix.cc_pkg}}" == "clang" ]]; then \
wget https://apt.llvm.org/llvm.sh -O /tmp/llvm.sh; \
- sudo bash /tmp/llvm.sh 15; \
- sudo update-alternatives --install /usr/bin/clang++ clang++ /usr/bin/clang++-15 400; \
- sudo update-alternatives --install /usr/bin/clang clang /usr/bin/clang-15 400; \
+ sudo bash /tmp/llvm.sh 16; \
+ sudo update-alternatives --install /usr/bin/clang++ clang++ /usr/bin/clang++-16 400; \
+ sudo update-alternatives --install /usr/bin/clang clang /usr/bin/clang-16 400; \
else \
sudo apt-get update -y; \
sudo apt-get install -y ${{matrix.cc_pkg}} ${{matrix.cxx_pkg}}; \
fi;
- name: Display compiler versions
--
Ammar Faizi
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH liburing v1 2/3] CHANGELOG: Note about `io_uring_{enter,enter2,register,setup}`
2022-08-31 0:48 [PATCH liburing v1 0/3] liburing updates Ammar Faizi
2022-08-31 0:48 ` [PATCH liburing v1 1/3] github bot: Upgrade clang version to 16 Ammar Faizi
@ 2022-08-31 0:48 ` Ammar Faizi
2022-08-31 0:48 ` [PATCH liburing v1 3/3] queue: Remove unnecessary goto and label Ammar Faizi
2022-08-31 1:00 ` [PATCH liburing v1 0/3] liburing updates Jens Axboe
3 siblings, 0 replies; 5+ messages in thread
From: Ammar Faizi @ 2022-08-31 0:48 UTC (permalink / raw)
To: Jens Axboe
Cc: Ammar Faizi, Muhammad Rizki, Kanna Scarlet, io-uring Mailing List,
Linux Kernel Mailing List, GNU/Weeb Mailing List
From: Ammar Faizi <[email protected]>
Commit f0b43c84cb3d1 ("syscall: Add io_uring syscall functions")
exports 4 new functions. Mention it in the CHANGELOG file.
Signed-off-by: Ammar Faizi <[email protected]>
---
CHANGELOG | 1 +
1 file changed, 1 insertion(+)
diff --git a/CHANGELOG b/CHANGELOG
index 9c054b0..1f37e92 100644
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -1,9 +1,10 @@
liburing-2.3 release
- Support non-libc build for aarch64.
+- Add io_uring_{enter,enter2,register,setup} syscall functions.
liburing-2.2 release
- Support non-libc builds.
- Optimized syscall handling for x86-64/x86/aarch64.
--
Ammar Faizi
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH liburing v1 3/3] queue: Remove unnecessary goto and label
2022-08-31 0:48 [PATCH liburing v1 0/3] liburing updates Ammar Faizi
2022-08-31 0:48 ` [PATCH liburing v1 1/3] github bot: Upgrade clang version to 16 Ammar Faizi
2022-08-31 0:48 ` [PATCH liburing v1 2/3] CHANGELOG: Note about `io_uring_{enter,enter2,register,setup}` Ammar Faizi
@ 2022-08-31 0:48 ` Ammar Faizi
2022-08-31 1:00 ` [PATCH liburing v1 0/3] liburing updates Jens Axboe
3 siblings, 0 replies; 5+ messages in thread
From: Ammar Faizi @ 2022-08-31 0:48 UTC (permalink / raw)
To: Jens Axboe
Cc: Ammar Faizi, Muhammad Rizki, Kanna Scarlet, io-uring Mailing List,
Linux Kernel Mailing List, GNU/Weeb Mailing List
From: Ammar Faizi <[email protected]>
This 'goto done' and 'done:' label are not needed, there is no cleanup
needed in this path. Simplify it. Just return 0 directly.
Signed-off-by: Ammar Faizi <[email protected]>
---
src/queue.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/queue.c b/src/queue.c
index 277cdcc..a670a8e 100644
--- a/src/queue.c
+++ b/src/queue.c
@@ -158,25 +158,24 @@ again:
cqes[i] = &ring->cq.cqes[(head & mask) << shift];
return count;
}
if (overflow_checked)
- goto done;
+ return 0;
if (cq_ring_needs_flush(ring)) {
int flags = IORING_ENTER_GETEVENTS;
if (ring->int_flags & INT_FLAG_REG_RING)
flags |= IORING_ENTER_REGISTERED_RING;
__sys_io_uring_enter(ring->enter_ring_fd, 0, 0, flags, NULL);
overflow_checked = true;
goto again;
}
-done:
return 0;
}
/*
* Sync internal state with kernel ring state on the SQ side. Returns the
* number of pending items in the SQ ring, for the shared ring.
--
Ammar Faizi
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH liburing v1 0/3] liburing updates
2022-08-31 0:48 [PATCH liburing v1 0/3] liburing updates Ammar Faizi
` (2 preceding siblings ...)
2022-08-31 0:48 ` [PATCH liburing v1 3/3] queue: Remove unnecessary goto and label Ammar Faizi
@ 2022-08-31 1:00 ` Jens Axboe
3 siblings, 0 replies; 5+ messages in thread
From: Jens Axboe @ 2022-08-31 1:00 UTC (permalink / raw)
To: Ammar Faizi
Cc: io-uring Mailing List, Linux Kernel Mailing List, Kanna Scarlet,
GNU/Weeb Mailing List, Muhammad Rizki
On Wed, 31 Aug 2022 07:48:14 +0700, Ammar Faizi wrote:
> From: Ammar Faizi <[email protected]>
>
> Hi Jens,
>
> Just small liburing updates this time.
>
> 1) github bot: Upgrade clang version to 16.
>
> [...]
Applied, thanks!
[1/3] github bot: Upgrade clang version to 16
commit: 43cc51831a602cae3b9424dc762e3bff9f87a291
[2/3] CHANGELOG: Note about `io_uring_{enter,enter2,register,setup}`
commit: 56d72cb2ce23ec06b8c96ec94a1be92339859dea
[3/3] queue: Remove unnecessary goto and label
commit: a71d56ef3259216739677473ddb17ad861c3a964
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 5+ messages in thread