From: Jens Axboe <[email protected]>
To: [email protected], Pavel Begunkov <[email protected]>
Cc: Stefan Metzmacher <[email protected]>
Subject: Re: [PATCH for-6.1] io_uring/net: don't skip notifs for failed requests
Date: Wed, 28 Sep 2022 07:53:39 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <9c8bead87b2b980fcec441b8faef52188b4a6588.1664292100.git.asml.silence@gmail.com>
On Wed, 28 Sep 2022 00:51:49 +0100, Pavel Begunkov wrote:
> We currently only add a notification CQE when the send succeded, i.e.
> cqe.res >= 0. However, it'd be more robust to do buffer notifications
> for failed requests as well in case drivers decide do something fanky.
>
> Always return a buffer notification after initial prep, don't hide it.
> This behaviour is better aligned with documentation and the patch also
> helps the userspace to respect it.
>
> [...]
Applied, thanks!
[1/1] io_uring/net: don't skip notifs for failed requests
commit: 6ae91ac9a6aa7d6005c3c6d0f4d263fbab9f377f
Best regards,
--
Jens Axboe
next prev parent reply other threads:[~2022-09-28 13:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 23:51 [PATCH for-6.1] io_uring/net: don't skip notifs for failed requests Pavel Begunkov
2022-09-28 13:53 ` Jens Axboe [this message]
2022-09-28 15:23 ` Stefan Metzmacher
2022-09-28 16:56 ` Pavel Begunkov
2022-09-28 18:58 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166437321950.10271.14794575735421337726.b4-ty@kernel.dk \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox