From: Jens Axboe <[email protected]>
To: [email protected], Pavel Begunkov <[email protected]>
Subject: Re: [PATCH 1/1] io_uring: optimise mb() in io_req_local_work_add
Date: Thu, 06 Oct 2022 07:40:40 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <43983bc8bc507172adda7a0f00cab1aff09fd238.1665018309.git.asml.silence@gmail.com>
On Thu, 6 Oct 2022 02:06:10 +0100, Pavel Begunkov wrote:
> io_cqring_wake() needs a barrier for the waitqueue_active() check.
> However, in case of io_req_local_work_add() prior it calls llist_add(),
> which implies an atomic, and with that we can replace smb_mb() with
> smp_mb__after_atomic().
>
>
Applied, thanks!
[1/1] io_uring: optimise mb() in io_req_local_work_add
commit: b4f5d4f4e12def53462ea7f35dafa132f2d54156
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2022-10-06 13:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 1:06 [PATCH 1/1] io_uring: optimise mb() in io_req_local_work_add Pavel Begunkov
2022-10-06 13:40 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166506364006.7863.2864738975982549695.b4-ty@kernel.dk \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox