public inbox for [email protected]
 help / color / mirror / Atom feed
* [PATCH v1] io_uring: remove outdated comments of caching
@ 2022-11-10  6:03 Lin Ma
  2022-11-10 18:16 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Lin Ma @ 2022-11-10  6:03 UTC (permalink / raw)
  To: axboe, asml.silence, io-uring, linux-kernel; +Cc: Lin Ma

Previous commit 13a99017ff19 ("io_uring: remove events caching
atavisms") entirely removes the events caching optimization introduced 
by commit 81459350d581 ("io_uring: cache req->apoll->events in
req->cflags"). Hence the related comment should also be removed to avoid
misunderstanding.

Fixes: 13a99017ff19 ("io_uring: remove events caching atavisms")
Signed-off-by: Lin Ma <[email protected]>
---
 io_uring/poll.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/io_uring/poll.c b/io_uring/poll.c
index 0d9f49c575e0..74ba910c1f22 100644
--- a/io_uring/poll.c
+++ b/io_uring/poll.c
@@ -310,12 +310,7 @@ static void io_apoll_task_func(struct io_kiocb *req, bool *locked)
 static void __io_poll_execute(struct io_kiocb *req, int mask)
 {
 	io_req_set_res(req, mask, 0);
-	/*
-	 * This is useful for poll that is armed on behalf of another
-	 * request, and where the wakeup path could be on a different
-	 * CPU. We want to avoid pulling in req->apoll->events for that
-	 * case.
-	 */
+
 	if (req->opcode == IORING_OP_POLL_ADD)
 		req->io_task_work.func = io_poll_task_func;
 	else
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v1] io_uring: remove outdated comments of caching
  2022-11-10  6:03 [PATCH v1] io_uring: remove outdated comments of caching Lin Ma
@ 2022-11-10 18:16 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2022-11-10 18:16 UTC (permalink / raw)
  To: io-uring, linux-kernel, Lin Ma, asml.silence

On Thu, 10 Nov 2022 14:03:13 +0800, Lin Ma wrote:
> Previous commit 13a99017ff19 ("io_uring: remove events caching
> atavisms") entirely removes the events caching optimization introduced
> by commit 81459350d581 ("io_uring: cache req->apoll->events in
> req->cflags"). Hence the related comment should also be removed to avoid
> misunderstanding.
> 
> 
> [...]

Applied, thanks!

[1/1] io_uring: remove outdated comments of caching
      commit: ff611c848d0fd408ce90ef93a09ea0a70400cd86

Best regards,
-- 
Jens Axboe



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-11-10 18:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-10  6:03 [PATCH v1] io_uring: remove outdated comments of caching Lin Ma
2022-11-10 18:16 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox