[PATCH for-next 1/1] io_uring: inline __io_req_complete_post()

[PATCH for-next 1/1] io_uring: inline __io_req_complete_post()

[Pavel Begunkov]

There is only one user of __io_req_complete_post(), inline it.

Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
---
 io_uring/io_uring.c | 11 +++--------
 io_uring/io_uring.h |  1 -
 2 files changed, 3 insertions(+), 9 deletions(-)

diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c
index 94329c1ce91d..2087ada65284 100644
--- a/io_uring/io_uring.c
+++ b/io_uring/io_uring.c
@@ -844,19 +844,14 @@ static void __io_req_complete_put(struct io_kiocb *req)
 	}
 }
 
-void __io_req_complete_post(struct io_kiocb *req)
-{
-	if (!(req->flags & REQ_F_CQE_SKIP))
-		__io_fill_cqe_req(req->ctx, req);
-	__io_req_complete_put(req);
-}
-
 void io_req_complete_post(struct io_kiocb *req)
 {
 	struct io_ring_ctx *ctx = req->ctx;
 
 	io_cq_lock(ctx);
-	__io_req_complete_post(req);
+	if (!(req->flags & REQ_F_CQE_SKIP))
+		__io_fill_cqe_req(ctx, req);
+	__io_req_complete_put(req);
 	io_cq_unlock_post(ctx);
 }
 
diff --git a/io_uring/io_uring.h b/io_uring/io_uring.h
index 0b0620e2bf4b..af3f82bd4017 100644
--- a/io_uring/io_uring.h
+++ b/io_uring/io_uring.h
@@ -32,7 +32,6 @@ int io_run_local_work(struct io_ring_ctx *ctx);
 void io_req_complete_failed(struct io_kiocb *req, s32 res);
 void __io_req_complete(struct io_kiocb *req, unsigned issue_flags);
 void io_req_complete_post(struct io_kiocb *req);
-void __io_req_complete_post(struct io_kiocb *req);
 bool io_post_aux_cqe(struct io_ring_ctx *ctx, u64 user_data, s32 res, u32 cflags);
 bool io_fill_cqe_aux(struct io_ring_ctx *ctx, u64 user_data, s32 res, u32 cflags);
 void __io_commit_cqring_flush(struct io_ring_ctx *ctx);
-- 
2.38.1

Re: [PATCH for-next 1/1] io_uring: inline __io_req_complete_post()

[Jens Axboe]

On Thu, 17 Nov 2022 18:41:06 +0000, Pavel Begunkov wrote:
> There is only one user of __io_req_complete_post(), inline it.
> 
> 

Applied, thanks!

[1/1] io_uring: inline __io_req_complete_post()
      commit: e353d23f304aad9ca0215cc0051757611686e34d

Best regards,
-- 
Jens Axboe

Re: [PATCH for-next 1/1] io_uring: inline __io_req_complete_post()

[Gabriel Krisman Bertazi]

Pavel Begunkov <asml.silence@gmail.com> writes:

> There is only one user of __io_req_complete_post(), inline it.

Probably already inlined by the compiler, so shouldn't be a problem.
Feel free to add:

Reviewed-by: Gabriel Krisman Bertazi <krisman@suse.de>

Thanks,

-- 
Gabriel Krisman Bertazi