From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B53F8C43217 for ; Fri, 18 Nov 2022 16:29:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235242AbiKRQ3r (ORCPT ); Fri, 18 Nov 2022 11:29:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242010AbiKRQ3q (ORCPT ); Fri, 18 Nov 2022 11:29:46 -0500 Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BF6F109A for ; Fri, 18 Nov 2022 08:29:45 -0800 (PST) Received: by mail-io1-xd33.google.com with SMTP id d123so4186860iof.7 for ; Fri, 18 Nov 2022 08:29:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:to:from:from:to:cc:subject:date:message-id :reply-to; bh=h5Ex91eT1z0YVGUD2xs+1Qz5a25lfzUWwJxTOeAGf3M=; b=iqVMW3Rbbavv98kOExuBqB1YP2q/Wwgfu8+6Cc5WAgvwsJquT7mH0FXQ3EUTYhDaXM cEv72HLI01nluHdsXKYMTNMxuzJI5E/aKMmGdiiRoegw+r24YEdEvU2s3JzxGUahr1rI rW8w3yU6mvtbetsenuRvoYQDIXE2bPN9cxvt5fAdgTEZAN282FZw7v6E8LoUVDrwVeZS Ji5i6ibY77iQQrucbmYp9XC4ZsViyi4qmAHeYOSzXY3hQc3npFen+b+VZCpTZIBwDhaw /6mxPdD4MQM/vsMkslaNCyCZnWgD6sSn+KnNuxuT+PyD9qK8F1N3zfFXUeNY1Dzbb7b4 Y24A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h5Ex91eT1z0YVGUD2xs+1Qz5a25lfzUWwJxTOeAGf3M=; b=ZCxegfPbjcq8bCmSm/+SdW5hleF/AEY4JojuzfxRJQkiRASLWMOBcZYKurTVSh2Z3y 6XpcA0dOLDv3osgeFwNbJgmW4JjzlXzooY34Dx3rmyRLf2Mb0ILtCi8KopgDd9eBKwQz cvhJkIp9NyW14fSwn3gu2xEyabkqW8QXtwXxAIU3LFA0iTPaC6M5r4OJavcodXYDuJAi g1eVDLdQCTIHivB5O34u6TpkoRpAepdXfGJpXuSf1azD1EpYbR/90yAeSF54chd9Nz1T nyrMaVloo/uulZ064hkHqvpeMuR91C3tnJSMcRsyMWFozHDh3WOlqhnZ6yikT8jY8KS4 o1Qw== X-Gm-Message-State: ANoB5pkN8gclyouSXgrOInweIcpBka1kUd7C6trRNGEfHvorMNdklT9T 5MNQOJrvyZzVwlMlvycRMbiwEHVDqBjciw== X-Google-Smtp-Source: AA0mqf6M5bA+oygpHINRRaaI2IM9Gh8WBdZ4CcgDXsGF6MemCQu3Sc06HR8Zmppung9MMNkVkz7cjQ== X-Received: by 2002:a02:5146:0:b0:371:1431:d4f2 with SMTP id s67-20020a025146000000b003711431d4f2mr3598770jaa.184.1668788984716; Fri, 18 Nov 2022 08:29:44 -0800 (PST) Received: from [127.0.0.1] ([207.135.234.126]) by smtp.gmail.com with ESMTPSA id p18-20020a92d692000000b002ffcf2e2e05sm1357521iln.58.2022.11.18.08.29.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Nov 2022 08:29:43 -0800 (PST) From: Jens Axboe To: Pavel Begunkov , io-uring@vger.kernel.org In-Reply-To: <3124038c0e7474d427538c2d915335ec28c92d21.1668785722.git.asml.silence@gmail.com> References: <3124038c0e7474d427538c2d915335ec28c92d21.1668785722.git.asml.silence@gmail.com> Subject: Re: [PATCH for-6.1] io_uring: disallow self-propelled ring polling Message-Id: <166878898377.7355.14584218754403506688.b4-ty@kernel.dk> Date: Fri, 18 Nov 2022 09:29:43 -0700 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailer: b4 0.11.0-dev-28747 Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Fri, 18 Nov 2022 15:41:41 +0000, Pavel Begunkov wrote: > When we post a CQE we wake all ring pollers as it normally should be. > However, if a CQE was generated by a multishot poll request targeting > its own ring, it'll wake that request up, which will make it to post > a new CQE, which will wake the request and so on until it exhausts all > CQ entries. > > Don't allow multishot polling io_uring files but downgrade them to > oneshots, which was always stated as a correct behaviour that the > userspace should check for. > > [...] Applied, thanks! [1/1] io_uring: disallow self-propelled ring polling commit: 7fdbc5f014c3f71bc44673a2d6c5bb2d12d45f25 Best regards, -- Jens Axboe