From: Jens Axboe <[email protected]>
To: Gabriel Krisman Bertazi <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH liburing] test/helpers: fix socket length type
Date: Wed, 18 Jan 2023 07:57:08 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On Wed, 18 Jan 2023 11:48:06 -0300, Gabriel Krisman Bertazi wrote:
> t_create_socket_pair uses size_t for paddrlen, which is uint64 on 64-bit
> architecture, while the network syscalls expect uint32. The implicit
> cast is always safe for little-endian here due to the structure format,
> its small size and the fact it was previously zeroed - so the test
> succeeds.
>
> Still, on BE machines, our CI caught a few tests crashing on
> connect(). For instance:
>
> [...]
Applied, thanks!
[1/1] test/helpers: fix socket length type
commit: b5caa618565c0c6d0053f7b1bae2423cd317660c
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2023-01-18 15:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 14:48 [PATCH liburing] test/helpers: fix socket length type Gabriel Krisman Bertazi
2023-01-18 14:57 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167405382855.134458.8843645998540843384.b4-ty@kernel.dk \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox