* [PATCH for-next 1/1] io_uring/rsrc: fix a comment in io_import_fixed()
@ 2023-02-20 14:13 Pavel Begunkov
2023-02-20 14:53 ` Gabriel Krisman Bertazi
2023-02-22 16:53 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Pavel Begunkov @ 2023-02-20 14:13 UTC (permalink / raw)
To: io-uring; +Cc: Jens Axboe, asml.silence
io_import_fixed() supports offsets, but "may not" means the opposite.
Replace it with "might not" so the comments rather speaks about
possible cases.
Signed-off-by: Pavel Begunkov <[email protected]>
---
io_uring/rsrc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/io_uring/rsrc.c b/io_uring/rsrc.c
index 70d7f94670f9..7a915a58eb38 100644
--- a/io_uring/rsrc.c
+++ b/io_uring/rsrc.c
@@ -1336,7 +1336,7 @@ int io_import_fixed(int ddir, struct iov_iter *iter,
return -EFAULT;
/*
- * May not be a start of buffer, set size appropriately
+ * Might not be a start of buffer, set size appropriately
* and advance us to the beginning.
*/
offset = buf_addr - imu->ubuf;
--
2.39.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH for-next 1/1] io_uring/rsrc: fix a comment in io_import_fixed()
2023-02-20 14:13 [PATCH for-next 1/1] io_uring/rsrc: fix a comment in io_import_fixed() Pavel Begunkov
@ 2023-02-20 14:53 ` Gabriel Krisman Bertazi
2023-02-22 16:53 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Gabriel Krisman Bertazi @ 2023-02-20 14:53 UTC (permalink / raw)
To: Pavel Begunkov; +Cc: io-uring, Jens Axboe
Pavel Begunkov <[email protected]> writes:
> io_import_fixed() supports offsets, but "may not" means the opposite.
> Replace it with "might not" so the comments rather speaks about
> possible cases.
>
> Signed-off-by: Pavel Begunkov <[email protected]>
Reviewed-by: Gabriel Krisman Bertazi <[email protected]>
--
Gabriel Krisman Bertazi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH for-next 1/1] io_uring/rsrc: fix a comment in io_import_fixed()
2023-02-20 14:13 [PATCH for-next 1/1] io_uring/rsrc: fix a comment in io_import_fixed() Pavel Begunkov
2023-02-20 14:53 ` Gabriel Krisman Bertazi
@ 2023-02-22 16:53 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2023-02-22 16:53 UTC (permalink / raw)
To: io-uring, Pavel Begunkov
On Mon, 20 Feb 2023 14:13:52 +0000, Pavel Begunkov wrote:
> io_import_fixed() supports offsets, but "may not" means the opposite.
> Replace it with "might not" so the comments rather speaks about
> possible cases.
>
>
Applied, thanks!
[1/1] io_uring/rsrc: fix a comment in io_import_fixed()
commit: 81da9e3accfcf978b87300629190d164228c8b8c
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-22 16:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-20 14:13 [PATCH for-next 1/1] io_uring/rsrc: fix a comment in io_import_fixed() Pavel Begunkov
2023-02-20 14:53 ` Gabriel Krisman Bertazi
2023-02-22 16:53 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox