From: Jens Axboe <[email protected]>
To: Wojciech Lukowicz <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] io_uring: fix size calculation when registering buf ring
Date: Wed, 22 Feb 2023 09:54:00 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On Sat, 18 Feb 2023 18:41:41 +0000, Wojciech Lukowicz wrote:
> Using struct_size() to calculate the size of io_uring_buf_ring will sum
> the size of the struct and of the bufs array. However, the struct's fields
> are overlaid with the array making the calculated size larger than it
> should be.
>
> When registering a ring with N * PAGE_SIZE / sizeof(struct io_uring_buf)
> entries, i.e. with fully filled pages, the calculated size will span one
> more page than it should and io_uring will try to pin the following page.
> Depending on how the application allocated the ring, it might succeed
> using an unrelated page or fail returning EFAULT.
>
> [...]
Applied, thanks!
[1/1] io_uring: fix size calculation when registering buf ring
commit: 8318ba8fbd645d269f2e9a590f72f8bad8b5c295
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2023-02-22 16:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-18 18:41 [PATCH] io_uring: fix size calculation when registering buf ring Wojciech Lukowicz
2023-02-20 14:37 ` Gabriel Krisman Bertazi
2023-02-22 16:54 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167708484045.23363.7184504964007066401.b4-ty@kernel.dk \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox