From: Jens Axboe <[email protected]>
To: [email protected], Savino Dicanosa <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] io_uring/rsrc: fix null-ptr-deref in io_file_bitmap_get()
Date: Tue, 21 Mar 2023 13:57:26 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On Tue, 21 Mar 2023 19:44:02 +0000, Savino Dicanosa wrote:
> When fixed files are unregistered, file_alloc_end and alloc_hint
> are not cleared. This can later cause a NULL pointer dereference in
> io_file_bitmap_get() if auto index selection is enabled via
> IORING_FILE_INDEX_ALLOC:
>
> [ 6.519129] BUG: kernel NULL pointer dereference, address: 0000000000000000
> [...]
> [ 6.541468] RIP: 0010:_find_next_zero_bit+0x1a/0x70
> [...]
> [ 6.560906] Call Trace:
> [ 6.561322] <TASK>
> [ 6.561672] io_file_bitmap_get+0x38/0x60
> [ 6.562281] io_fixed_fd_install+0x63/0xb0
> [ 6.562851] ? __pfx_io_socket+0x10/0x10
> [ 6.563396] io_socket+0x93/0xf0
> [ 6.563855] ? __pfx_io_socket+0x10/0x10
> [ 6.564411] io_issue_sqe+0x5b/0x3d0
> [ 6.564914] io_submit_sqes+0x1de/0x650
> [ 6.565452] __do_sys_io_uring_enter+0x4fc/0xb20
> [ 6.566083] ? __do_sys_io_uring_register+0x11e/0xd80
> [ 6.566779] do_syscall_64+0x3c/0x90
> [ 6.567247] entry_SYSCALL_64_after_hwframe+0x72/0xdc
> [...]
>
> [...]
Applied, thanks!
[1/1] io_uring/rsrc: fix null-ptr-deref in io_file_bitmap_get()
commit: 761efd55a0227aca3a69deacdaa112fffd44fe37
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2023-03-21 19:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 19:44 [PATCH] io_uring/rsrc: fix null-ptr-deref in io_file_bitmap_get() Savino Dicanosa
2023-03-21 19:45 ` Jens Axboe
2023-03-21 19:57 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167942864607.555039.7575220089181396494.b4-ty@kernel.dk \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox