public inbox for [email protected]
 help / color / mirror / Atom feed
From: Jens Axboe <[email protected]>
To: Ammar Faizi <[email protected]>
Cc: "Barnabás Pőcze" <[email protected]>,
	"Michael William Jonathan" <[email protected]>,
	"Linux Kernel Mailing List" <[email protected]>,
	"io-uring Mailing List" <[email protected]>,
	"GNU/Weeb Mailing List" <[email protected]>
Subject: Re: [PATCH liburing v1 0/2] 2 fixes for recv-msgall.c
Date: Wed, 10 May 2023 09:17:52 -0600	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>


On Wed, 10 May 2023 21:39:25 +0700, Ammar Faizi wrote:
> This is the follow up patchset for the recent issue found in
> recv-msgall.c. There are two patches in this series.
> 
> 1. Fix undefined behavior in `recv_prep()`.
> The lifetime of `struct msghdr msg;` must be long enough until the CQE
> is generated because the recvmsg operation will write to that storage. I
> found this test segfault when compiling with -O0 optimization. This is
> undefined behavior and may behave randomly. Fix this by making the
> lifetime of `struct msghdr msg;` long enough.
> 
> [...]

Applied, thanks!

[1/2] recv-msgall: Fix undefined behavior in `recv_prep()`
      commit: 05c6317367cab6fd4b8cf38c68cea1563bf31c5f
[2/2] recv-msgall: Fix invalid mutex usage
      commit: 09c3661278bebb8431fbc10ed213e42181e7cac7

Best regards,
-- 
Jens Axboe




      parent reply	other threads:[~2023-05-10 15:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-10 14:39 [PATCH liburing v1 0/2] 2 fixes for recv-msgall.c Ammar Faizi
2023-05-10 14:39 ` [PATCH liburing v1 1/2] recv-msgall: Fix undefined behavior in `recv_prep()` Ammar Faizi
2023-05-10 14:39 ` [PATCH liburing v1 2/2] recv-msgall: Fix invalid mutex usage Ammar Faizi
2023-05-10 15:17 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=168373187265.405534.8990004306948050012.b4-ty@kernel.dk \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox