From: Jens Axboe <[email protected]>
To: [email protected], Wenwen Chen <[email protected]>
Cc: [email protected], Kanchan Joshi <[email protected]>
Subject: Re: [PATCH v2] io_uring: unlock sqd->lock before sq thread release CPU
Date: Thu, 25 May 2023 09:30:21 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On Thu, 25 May 2023 16:26:26 +0800, Wenwen Chen wrote:
> The sq thread actively releases CPU resources by calling the
> cond_resched() and schedule() interfaces when it is idle. Therefore,
> more resources are available for other threads to run.
>
> There exists a problem in sq thread: it does not unlock sqd->lock before
> releasing CPU resources every time. This makes other threads pending on
> sqd->lock for a long time. For example, the following interfaces all
> require sqd->lock: io_sq_offload_create(), io_register_iowq_max_workers()
> and io_ring_exit_work().
>
> [...]
Applied, thanks!
[1/1] io_uring: unlock sqd->lock before sq thread release CPU
commit: 533ab73f5b5c95dcb4152b52d5482abcc824c690
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2023-05-25 15:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230525082004epcas5p1d05da68508feff3f9dd82646a0b40aff@epcas5p1.samsung.com>
2023-05-25 8:26 ` [PATCH v2] io_uring: unlock sqd->lock before sq thread release CPU Wenwen Chen
2023-05-25 15:30 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168502862159.719490.14979738745453090363.b4-ty@kernel.dk \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox