* [PATCH] io_uring: fix off-by one bvec index
@ 2023-11-20 22:18 Keith Busch
2023-11-20 22:22 ` Jens Axboe
2023-11-21 14:42 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Keith Busch @ 2023-11-20 22:18 UTC (permalink / raw)
To: io-uring, asml.silence, axboe; +Cc: Keith Busch
From: Keith Busch <[email protected]>
If the offset equals the bv_len of the first registered bvec, then the
request does not include any of that first bvec. Skip it so that drivers
don't have to deal with a zero length bvec, which was observed to break
NVMe's PRP list creation.
Signed-off-by: Keith Busch <[email protected]>
---
io_uring/rsrc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/io_uring/rsrc.c b/io_uring/rsrc.c
index 7034be555334d..f521c5965a933 100644
--- a/io_uring/rsrc.c
+++ b/io_uring/rsrc.c
@@ -1258,7 +1258,7 @@ int io_import_fixed(int ddir, struct iov_iter *iter,
*/
const struct bio_vec *bvec = imu->bvec;
- if (offset <= bvec->bv_len) {
+ if (offset < bvec->bv_len) {
/*
* Note, huge pages buffers consists of one large
* bvec entry and should always go this way. The other
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] io_uring: fix off-by one bvec index
2023-11-20 22:18 [PATCH] io_uring: fix off-by one bvec index Keith Busch
@ 2023-11-20 22:22 ` Jens Axboe
2023-11-21 14:42 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2023-11-20 22:22 UTC (permalink / raw)
To: Keith Busch, io-uring, asml.silence; +Cc: Keith Busch
On 11/20/23 3:18 PM, Keith Busch wrote:
> From: Keith Busch <[email protected]>
>
> If the offset equals the bv_len of the first registered bvec, then the
> request does not include any of that first bvec. Skip it so that drivers
> don't have to deal with a zero length bvec, which was observed to break
> NVMe's PRP list creation.
Thanks Keith, that was fast (I sent in the report...). I applied this with
a fixes and stable tag.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] io_uring: fix off-by one bvec index
2023-11-20 22:18 [PATCH] io_uring: fix off-by one bvec index Keith Busch
2023-11-20 22:22 ` Jens Axboe
@ 2023-11-21 14:42 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2023-11-21 14:42 UTC (permalink / raw)
To: io-uring, asml.silence, Keith Busch; +Cc: Keith Busch
On Mon, 20 Nov 2023 14:18:31 -0800, Keith Busch wrote:
> If the offset equals the bv_len of the first registered bvec, then the
> request does not include any of that first bvec. Skip it so that drivers
> don't have to deal with a zero length bvec, which was observed to break
> NVMe's PRP list creation.
>
>
Applied, thanks!
[1/1] io_uring: fix off-by one bvec index
commit: d6fef34ee4d102be448146f24caf96d7b4a05401
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-21 14:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-20 22:18 [PATCH] io_uring: fix off-by one bvec index Keith Busch
2023-11-20 22:22 ` Jens Axboe
2023-11-21 14:42 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox