[PATCH liburing v1 0/2] Makefile and t/no-mmap-inval updates

[PATCH liburing v1 0/2] Makefile and t/no-mmap-inval updates

[Ammar Faizi]

Hi Jens,

There are two patches in this series:

1. Makefile: Remove the `partcheck` target.

Remove the `partcheck` target because it has remained unused for nearly
four years, and the associated TODO comment has not been actioned since
its introduction in commit:

  b57dbc2d308a849 ("configure/Makefile: introduce libdevdir defaults to $(libdir)")


2. t/no-mmap-inval: Replace `valloc()` with `t_posix_memalign()`.

Address the limitations of valloc(). This function, which is primarily
used for allocating page-aligned memory, is not only absent in some
systems but is also marked as obsolete according to the `man 3 valloc`.

Replace valloc() with t_posix_memalign() to fix the following build
error:

  no-mmap-inval.c:28:56: warning: call to undeclared function 'valloc'; ISO C99 and \
  later do not support implicit function declarations [-Wimplicit-function-declaration]
          p.cq_off.user_addr = (unsigned long long) (uintptr_t) valloc(8192);
                                                                ^
  1 warning generated.

  ld.lld: error: undefined symbol: valloc
  >>> referenced by no-mmap-inval.c:28
  >>>               /tmp/no-mmap-inval-ea16a2.o:(main)
  >>> did you mean: calloc
  >>> defined in: /system/lib64/libc.so
  clang-15: error: linker command failed with exit code 1 (use -v to see invocation)
  make[1]: *** [Makefile:239: no-mmap-inval.t] Error 1

Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
---
Ammar Faizi (2):
  Makefile: Remove the `partcheck` target
  t/no-mmap-inval: Replace `valloc()` with `t_posix_memalign()`

 Makefile             | 3 ---
 test/no-mmap-inval.c | 4 +++-
 2 files changed, 3 insertions(+), 4 deletions(-)


base-commit: bbd27495d302856b1f28d64b346d3ad80be3a86f
-- 
Ammar Faizi

[PATCH liburing v1 1/2] Makefile: Remove the `partcheck` target

[Ammar Faizi]

Remove the `partcheck` target because it has remained unused for nearly
four years, and the associated TODO comment has not been actioned since
its introduction in commit:

  b57dbc2d308a849 ("configure/Makefile: introduce libdevdir defaults to $(libdir)")

Cc: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
---
 Makefile | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/Makefile b/Makefile
index 73d021c2e46255bf..7326e644e3a18bdb 100644
--- a/Makefile
+++ b/Makefile
@@ -14,9 +14,6 @@ all:
 .PHONY: all install default clean test
 .PHONY: FORCE cscope
 
-partcheck: all
-	@echo "make partcheck => TODO add tests with out kernel support"
-
 runtests: all
 	@$(MAKE) -C test runtests
 runtests-loop: all
-- 
Ammar Faizi

[PATCH liburing v1 2/2] t/no-mmap-inval: Replace `valloc()` with `t_posix_memalign()`

[Ammar Faizi]

Address the limitations of valloc(). This function, which is primarily
used for allocating page-aligned memory, is not only absent in some
systems but is also marked as obsolete according to the `man 3 valloc`.

Replace valloc() with t_posix_memalign() to fix the following build
error:

  no-mmap-inval.c:28:56: warning: call to undeclared function 'valloc'; ISO C99 and \
  later do not support implicit function declarations [-Wimplicit-function-declaration]
          p.cq_off.user_addr = (unsigned long long) (uintptr_t) valloc(8192);
                                                                ^
  1 warning generated.

  ld.lld: error: undefined symbol: valloc
  >>> referenced by no-mmap-inval.c:28
  >>>               /tmp/no-mmap-inval-ea16a2.o:(main)
  >>> did you mean: calloc
  >>> defined in: /system/lib64/libc.so
  clang-15: error: linker command failed with exit code 1 (use -v to see invocation)
  make[1]: *** [Makefile:239: no-mmap-inval.t] Error 1

Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
---
 test/no-mmap-inval.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/test/no-mmap-inval.c b/test/no-mmap-inval.c
index 9571fee0035ac5ce..244d4eb645115a44 100644
--- a/test/no-mmap-inval.c
+++ b/test/no-mmap-inval.c
@@ -20,12 +20,14 @@ int main(int argc, char *argv[])
 		.flags		= IORING_SETUP_NO_MMAP,
 	};
 	struct io_uring ring;
+	void *addr;
 	int ret;
 
 	if (argc > 1)
 		return T_EXIT_SKIP;
 
-	p.cq_off.user_addr = (unsigned long long) (uintptr_t) valloc(8192);
+	t_posix_memalign(&addr, sysconf(_SC_PAGESIZE), 8192);
+	p.cq_off.user_addr = (unsigned long long) (uintptr_t) addr;
 
 	ret = io_uring_queue_init_params(2, &ring, &p);
 	if (ret == -EINVAL) {
-- 
Ammar Faizi

Re: [PATCH liburing v1 2/2] t/no-mmap-inval: Replace `valloc()` with `t_posix_memalign()`

[Alviro Iskandar Setiawan]

On Tue, Dec 19, 2023 at 6:54 PM Ammar Faizi wrote:
> Address the limitations of valloc(). This function, which is primarily
> used for allocating page-aligned memory, is not only absent in some
> systems but is also marked as obsolete according to the `man 3 valloc`.
>
> Replace valloc() with t_posix_memalign() to fix the following build
> error:
>
>   no-mmap-inval.c:28:56: warning: call to undeclared function 'valloc'; ISO C99 and \
>   later do not support implicit function declarations [-Wimplicit-function-declaration]
>           p.cq_off.user_addr = (unsigned long long) (uintptr_t) valloc(8192);
>                                                                 ^
>   1 warning generated.
>
>   ld.lld: error: undefined symbol: valloc
>   >>> referenced by no-mmap-inval.c:28
>   >>>               /tmp/no-mmap-inval-ea16a2.o:(main)
>   >>> did you mean: calloc
>   >>> defined in: /system/lib64/libc.so
>   clang-15: error: linker command failed with exit code 1 (use -v to see invocation)
>   make[1]: *** [Makefile:239: no-mmap-inval.t] Error 1
>
> Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>

Reviewed-by: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>

-- Viro

Re: [PATCH liburing v1 0/2] Makefile and t/no-mmap-inval updates

[Jens Axboe]

On Tue, 19 Dec 2023 18:54:21 +0700, Ammar Faizi wrote:
> There are two patches in this series:
> 
> 1. Makefile: Remove the `partcheck` target.
> 
> Remove the `partcheck` target because it has remained unused for nearly
> four years, and the associated TODO comment has not been actioned since
> its introduction in commit:
> 
> [...]

Applied, thanks!

[1/2] Makefile: Remove the `partcheck` target
      commit: 4ea77f3a1561bbd3140cc0de03698a67d08f4f27
[2/2] t/no-mmap-inval: Replace `valloc()` with `t_posix_memalign()`
      commit: 7524a6adf4d6720a47bfa617b5cb2fd8d57f16d2

Best regards,
-- 
Jens Axboe