public inbox for [email protected]
 help / color / mirror / Atom feed
From: "Christoph Lameter (Ampere)" <[email protected]>
To: Lorenzo Stoakes <[email protected]>
Cc: Guenter Roeck <[email protected]>,
	 Geert Uytterhoeven <[email protected]>,
	 Vlastimil Babka <[email protected]>,
	Pekka Enberg <[email protected]>,
	 David Rientjes <[email protected]>,
	Joonsoo Kim <[email protected]>,
	 Andrew Morton <[email protected]>,
	 Roman Gushchin <[email protected]>,
	 Hyeonggon Yoo <[email protected]>,
	Jens Axboe <[email protected]>,
	 Pavel Begunkov <[email protected]>,
	Mike Rapoport <[email protected]>,
	 Christian Brauner <[email protected]>,
	Kees Cook <[email protected]>,  Jann Horn <[email protected]>,
	[email protected], [email protected],
	 [email protected], [email protected]
Subject: Re: [PATCH] slab: Fix too strict alignment check in create_cache()
Date: Fri, 22 Nov 2024 10:54:39 -0800 (PST)	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On Fri, 22 Nov 2024, Lorenzo Stoakes wrote:

> An aside, but note that there is a proposal to add nommu support to UML,
> which would entirely prevent our ability to eliminate it [0] (though it
> would make testing it easier! :)

Ok back to the alignment check. The patch is ok and an improvement since
it properly checks for the alignment of the scalar and does not assume
that a scalar is naturally aligned. That may not be necessary but it is
formally more correct.

So

Acked-by: Christoph Lameter <[email protected]>



  parent reply	other threads:[~2024-11-22 18:54 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-20 12:46 [PATCH] slab: Fix too strict alignment check in create_cache() Geert Uytterhoeven
2024-11-20 12:49 ` Geert Uytterhoeven
2024-11-20 15:00 ` Guenter Roeck
2024-11-20 15:01 ` Jens Axboe
2024-11-20 15:03 ` Vlastimil Babka
2024-11-20 15:14   ` Guenter Roeck
2024-11-20 15:44     ` Vlastimil Babka
2024-11-20 15:50       ` Geert Uytterhoeven
2024-11-20 17:50   ` Christoph Lameter (Ampere)
2024-11-21  3:51     ` Matthew Wilcox
2024-11-21  8:15     ` Geert Uytterhoeven
2024-11-21 17:23       ` Christoph Lameter (Ampere)
2024-11-21 18:30         ` Guenter Roeck
2024-11-21 18:35           ` Jens Axboe
2024-11-21 18:50           ` Geert Uytterhoeven
2024-11-21 19:08             ` Guenter Roeck
2024-11-21 19:22               ` Guenter Roeck
2024-11-22  9:45                 ` Lorenzo Stoakes
2024-11-22 12:55                   ` Lorenzo Stoakes
2024-11-22 18:54                   ` Christoph Lameter (Ampere) [this message]
2024-11-22  0:23           ` Greg Ungerer
2024-11-22  8:12             ` Geert Uytterhoeven
2024-11-22  8:25           ` Max Filippov
2024-11-21 10:19 ` Christian Brauner
2024-11-21 22:02 ` John Paul Adrian Glaubitz
2024-11-22  2:12   ` Finn Thain
2024-11-22  7:55     ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox