From: Jens Axboe <[email protected]>
To: [email protected], Pavel Begunkov <[email protected]>
Cc: Li Shi <[email protected]>
Subject: Re: [PATCH] io_uring: fix cancellation overwriting req->flags
Date: Fri, 14 Jun 2024 06:14:09 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <6827b129f8f0ad76fa9d1f0a773de938b240ffab.1718323430.git.asml.silence@gmail.com>
On Fri, 14 Jun 2024 01:04:29 +0100, Pavel Begunkov wrote:
> Only the current owner of a request is allowed to write into req->flags.
> Hence, the cancellation path should never touch it. Add a new field
> instead of the flag, move it into the 3rd cache line because it should
> always be initialised. poll_refs can move further as polling is an
> involved process anyway.
>
> It's a minimal patch, in the future we can and should find a better
> place for it and remove now unused REQ_F_CANCEL_SEQ.
>
> [...]
Applied, thanks!
[1/1] io_uring: fix cancellation overwriting req->flags
commit: f4a1254f2a076afb0edd473589bf40f9b4d36b41
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2024-06-14 12:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 0:04 [PATCH] io_uring: fix cancellation overwriting req->flags Pavel Begunkov
2024-06-14 12:14 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171836724941.222205.7286563058347838008.b4-ty@kernel.dk \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox