* [PATCH] io_uring/napi: Remove unnecessary s64 cast
@ 2024-07-10 1:05 Thorsten Blum
2024-07-10 6:23 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2024-07-10 1:05 UTC (permalink / raw)
To: axboe, asml.silence; +Cc: io-uring, linux-kernel, Thorsten Blum
Since the do_div() macro casts the divisor to u32 anyway, remove the
unnecessary s64 cast and fix the following Coccinelle/coccicheck
warning reported by do_div.cocci:
WARNING: do_div() does a 64-by-32 division, please consider using div64_s64 instead
Signed-off-by: Thorsten Blum <[email protected]>
---
io_uring/napi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/io_uring/napi.c b/io_uring/napi.c
index 8c18ede595c4..762254a7ff3f 100644
--- a/io_uring/napi.c
+++ b/io_uring/napi.c
@@ -283,7 +283,7 @@ void __io_napi_adjust_timeout(struct io_ring_ctx *ctx, struct io_wait_queue *iow
s64 poll_to_ns = timespec64_to_ns(ts);
if (poll_to_ns > 0) {
u64 val = poll_to_ns + 999;
- do_div(val, (s64) 1000);
+ do_div(val, 1000);
poll_to = val;
}
}
--
2.45.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] io_uring/napi: Remove unnecessary s64 cast
2024-07-10 1:05 [PATCH] io_uring/napi: Remove unnecessary s64 cast Thorsten Blum
@ 2024-07-10 6:23 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2024-07-10 6:23 UTC (permalink / raw)
To: asml.silence, Thorsten Blum; +Cc: io-uring, linux-kernel
On Wed, 10 Jul 2024 03:05:21 +0200, Thorsten Blum wrote:
> Since the do_div() macro casts the divisor to u32 anyway, remove the
> unnecessary s64 cast and fix the following Coccinelle/coccicheck
> warning reported by do_div.cocci:
>
> WARNING: do_div() does a 64-by-32 division, please consider using div64_s64 instead
>
>
> [...]
Applied, thanks!
[1/1] io_uring/napi: Remove unnecessary s64 cast
commit: f7c696a56cc7d70515774a24057b473757ec6089
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-10 6:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-10 1:05 [PATCH] io_uring/napi: Remove unnecessary s64 cast Thorsten Blum
2024-07-10 6:23 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox