From: Jens Axboe <[email protected]>
To: [email protected], Pavel Begunkov <[email protected]>
Cc: Kanchan Joshi <[email protected]>, Breno Leitao <[email protected]>
Subject: Re: [PATCH 1/1] io_uring: fix lost getsockopt completions
Date: Thu, 18 Jul 2024 14:34:27 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <ff349cf0654018189b6077e85feed935f0f8839e.1721149870.git.asml.silence@gmail.com>
On Tue, 16 Jul 2024 19:05:46 +0100, Pavel Begunkov wrote:
> There is a report that iowq executed getsockopt never completes. The
> reason being that io_uring_cmd_sock() can return a positive result, and
> io_uring_cmd() propagates it back to core io_uring, instead of IOU_OK.
> In case of io_wq_submit_work(), the request will be dropped without
> completing it.
>
> The offending code was introduced by a hack in
> a9c3eda7eada9 ("io_uring: fix submission-failure handling for uring-cmd"),
> however it was fine until getsockopt was introduced and started
> returning positive results.
>
> [...]
Applied, thanks!
[1/1] io_uring: fix lost getsockopt completions
commit: 2554b855a2f8605407a2018ca55cabb1af1feb61
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2024-07-18 20:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-16 18:05 [PATCH 1/1] io_uring: fix lost getsockopt completions Pavel Begunkov
2024-07-16 18:48 ` Breno Leitao
2024-07-18 20:34 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172133486720.46273.6648440231001293393.b4-ty@kernel.dk \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox