public inbox for [email protected]
 help / color / mirror / Atom feed
From: Jens Axboe <[email protected]>
To: [email protected], Pavel Begunkov <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH 1/1] io_uring: fix error pbuf checking
Date: Thu, 18 Jul 2024 14:34:28 -0600	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <c5f9df20560bd9830401e8e48abc029e7cfd9f5e.1721329239.git.asml.silence@gmail.com>


On Thu, 18 Jul 2024 20:00:53 +0100, Pavel Begunkov wrote:
> Syz reports a problem, which boils down to NULL vs IS_ERR inconsistent
> error handling in io_alloc_pbuf_ring().
> 
> KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007]
> RIP: 0010:__io_remove_buffers+0xac/0x700 io_uring/kbuf.c:341
> Call Trace:
>  <TASK>
>  io_put_bl io_uring/kbuf.c:378 [inline]
>  io_destroy_buffers+0x14e/0x490 io_uring/kbuf.c:392
>  io_ring_ctx_free+0xa00/0x1070 io_uring/io_uring.c:2613
>  io_ring_exit_work+0x80f/0x8a0 io_uring/io_uring.c:2844
>  process_one_work kernel/workqueue.c:3231 [inline]
>  process_scheduled_works+0xa2c/0x1830 kernel/workqueue.c:3312
>  worker_thread+0x86d/0xd40 kernel/workqueue.c:3390
>  kthread+0x2f0/0x390 kernel/kthread.c:389
>  ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:147
>  ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244
> 
> [...]

Applied, thanks!

[1/1] io_uring: fix error pbuf checking
      commit: 77feb9505ce67fc609b1e7b6b27b41995370498f

Best regards,
-- 
Jens Axboe




      reply	other threads:[~2024-07-18 20:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-18 19:00 [PATCH 1/1] io_uring: fix error pbuf checking Pavel Begunkov
2024-07-18 20:34 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=172133486834.46273.15978838697580136389.b4-ty@kernel.dk \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox