From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BF92C433F5 for ; Thu, 10 Feb 2022 02:08:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230354AbiBJCIp (ORCPT ); Wed, 9 Feb 2022 21:08:45 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:54636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234839AbiBJCIO (ORCPT ); Wed, 9 Feb 2022 21:08:14 -0500 Received: from gnuweeb.org (gnuweeb.org [51.81.211.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08658240A8 for ; Wed, 9 Feb 2022 18:06:22 -0800 (PST) Received: from [192.168.88.87] (unknown [36.68.63.145]) by gnuweeb.org (Postfix) with ESMTPSA id 73C127E25B; Thu, 10 Feb 2022 02:06:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1644458782; bh=jdM+Ls76kLkVKW/0JjGIz/frGpIS6RVEtCcG8wfl8Wk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Zn3oUi+ojo9ckftgDkTWaZJ+U/tWpdY6xNocRrgQkN5rfIxWIeL+qh6fh6MxDxN9y 4RW0kAvCJWcdU1KYJvg4anmIkaTXixSqQA20DeBuzwsWA1r+cwbQ93TBcsQApapgZw ubUAM8CjZMHfcFrMDIzbCtU8GBqUoMxc8wNidJTMdj+KApoNSVpsLibJzgzy3Xpwgj Rq+FNkyL7d3km33bnSqFgk4oI4Z6wP9GEVIOuK1fF1wHreK2+x9DBe7bXolJBB74YT txxPHN29gV1pn4/mkHedL+ReILYSsH2nkyyZbvGqK+FmnqBb58WYYYyffT7IoRRHjy zsI4vX05dDVug== Message-ID: <1721c3be-27b3-fcd8-c048-0f39eaacca68@gnuweeb.org> Date: Thu, 10 Feb 2022 09:06:06 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v1] liburing: add test for stable statx api Content-Language: en-US To: Stefan Roesch , io-uring@vger.kernel.org, kernel-team@fb.com Cc: viro@zeniv.linux.org.uk References: <20220209190430.2378305-1-shr@fb.com> From: Ammar Faizi In-Reply-To: <20220209190430.2378305-1-shr@fb.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 2/10/22 2:04 AM, Stefan Roesch wrote: > This adds a test for the statx api to verify that io-uring statx api is > stable. > > Signed-off-by: Stefan Roesch > --- > test/statx.c | 65 ++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 65 insertions(+) > > diff --git a/test/statx.c b/test/statx.c > index c0f9e9c..61268d4 100644 > --- a/test/statx.c > +++ b/test/statx.c > @@ -77,6 +77,61 @@ err: > return -1; > } > > +static int test_statx_stable(struct io_uring *ring, const char *path) > +{ > + struct io_uring_cqe *cqe; > + struct io_uring_sqe *sqe; > + struct statx x1, x2; > + char path1[PATH_MAX]; > + char path2[PATH_MAX]; > + int ret = -1; > + > + strcpy(path2, path); > + strcpy(path1, path); > + > + sqe = io_uring_get_sqe(ring); > + if (!sqe) { > + fprintf(stderr, "get sqe failed\n"); > + goto err; > + } > + > + io_uring_prep_statx(sqe, -1, path1, 0, STATX_ALL, &x1); > + > + ret = io_uring_submit(ring); > + if (ret <= 0) { > + fprintf(stderr, "sqe submit failed: %d\n", ret); > + goto err; > + } > + memset(path1, 0, sizeof(path1)); > + > + ret = io_uring_wait_cqe(ring, &cqe); > + if (ret < 0) { > + fprintf(stderr, "wait completion %d\n", ret); > + goto err; > + } > + > + ret = cqe->res; > + io_uring_cqe_seen(ring, cqe); > + if (ret) { > + fprintf(stderr, "statx res = %d\n", ret); > + goto err; > + } > + > + ret = do_statx(-1, path2, 0, STATX_ALL, &x2); > + if (ret < 0) > + return statx_syscall_supported(); > + > + if (memcmp(&x1, &x2, sizeof(x1))) { > + fprintf(stderr, "Miscompare between io_uring and statx\n"); > + goto err; > + } If we fail on memcmp() here, the ret should be set to non-zero *explicitly*. Otherwise, we have zero exit code since statx returns 0 on success. I think that one can also be simplified like this: [...] ret = memcmp(&x1, &x2, sizeof(x1)); if (ret) fprintf(stderr, "Miscompare between io_uring and statx\n"); err: return ret; } > + > + ret = 0; > + > +err: > + return ret; > +} > + > static int test_statx_fd(struct io_uring *ring, const char *path) > { > struct io_uring_cqe *cqe; > @@ -156,6 +211,16 @@ int main(int argc, char *argv[]) > goto err; > } > > + ret = test_statx_stable(&ring, fname); > + if (ret) { > + if (ret == -EINVAL) { > + fprintf(stdout, "statx not supported, skipping\n"); > + goto done; > + } > + fprintf(stderr, "test_statx_loop failed: %d\n", ret); > + goto err; > + } > + > ret = test_statx_fd(&ring, fname); > if (ret) { > fprintf(stderr, "test_statx_fd failed: %d\n", ret); > > base-commit: d9b0a424471f5c584f1d3f370e1746925733c01a -- Ammar Faizi