public inbox for [email protected]
 help / color / mirror / Atom feed
* [PATCH] io_uring: fix user_data field name in comment
@ 2024-08-16 18:15 Caleb Sander Mateos
  2024-08-16 18:31 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Caleb Sander Mateos @ 2024-08-16 18:15 UTC (permalink / raw)
  To: Jens Axboe, Pavel Begunkov; +Cc: Caleb Sander Mateos, io-uring, linux-kernel

io_uring_cqe's user_data field refers to `sqe->data`, but io_uring_sqe
does not have a data field. Fix the comment to say `sqe->user_data`.

Signed-off-by: Caleb Sander Mateos <[email protected]>
Link: https://github.com/axboe/liburing/pull/1206
---
 include/uapi/linux/io_uring.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/uapi/linux/io_uring.h b/include/uapi/linux/io_uring.h
index 48c440edf674..7af716136df9 100644
--- a/include/uapi/linux/io_uring.h
+++ b/include/uapi/linux/io_uring.h
@@ -419,11 +419,11 @@ enum io_uring_msg_ring_flags {
 
 /*
  * IO completion data structure (Completion Queue Entry)
  */
 struct io_uring_cqe {
-	__u64	user_data;	/* sqe->data submission passed back */
+	__u64	user_data;	/* sqe->user_data value passed back */
 	__s32	res;		/* result code for this event */
 	__u32	flags;
 
 	/*
 	 * If the ring is initialized with IORING_SETUP_CQE32, then this field
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] io_uring: fix user_data field name in comment
  2024-08-16 18:15 [PATCH] io_uring: fix user_data field name in comment Caleb Sander Mateos
@ 2024-08-16 18:31 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2024-08-16 18:31 UTC (permalink / raw)
  To: Pavel Begunkov, Caleb Sander Mateos; +Cc: io-uring, linux-kernel


On Fri, 16 Aug 2024 12:15:23 -0600, Caleb Sander Mateos wrote:
> io_uring_cqe's user_data field refers to `sqe->data`, but io_uring_sqe
> does not have a data field. Fix the comment to say `sqe->user_data`.
> 
> 

Applied, thanks!

[1/1] io_uring: fix user_data field name in comment
      commit: 1fc2ac428ef7d2ab9e8e19efe7ec3e58aea51bf3

Best regards,
-- 
Jens Axboe




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-08-16 18:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-16 18:15 [PATCH] io_uring: fix user_data field name in comment Caleb Sander Mateos
2024-08-16 18:31 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox