From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87B52125D5 for ; Tue, 17 Sep 2024 02:22:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726539774; cv=none; b=EBpKCpJIzFIHydleB1qGecDPap3XtpzMB4acdZYKCQV1Iyw53YWJZTlSxxdMIY0+StF7bYFlXRvsHC3LgpwdE6WA4uL++51JWK1ikrAiua1qtAMPU267yCqsQ8zX7jmVErefvyLBJKqFoAIEe1DXgnh5yWH1MugWOOv7cj6TEtw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726539774; c=relaxed/simple; bh=/fTI3aUKjRCjKJF9bh/6FeODJWbFRJsBatVLeDhs0Hs=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=awzwFn0TvQ2XZLhAZ3d3p1j+ng0rOiQbNl2qTe35W7rP5m0llIkiKjOI3jvoGfh+QltTjWAhJFLdx2/3XO/YpWVuyFFCP8ytBn3tTtn8qCNw18p5tiOWUIy/5WZWwNpnPCAjk6zcbtPkBJH1DttvVvrmO1KlYOwcYPpGSWDFYwg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=mL02fGcz; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="mL02fGcz" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-42cbbb1727eso42054675e9.2 for ; Mon, 16 Sep 2024 19:22:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1726539769; x=1727144569; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ymm14DvclZR6EwNa1VR+Y/QCzcjsiiSSfxF2e1CPRak=; b=mL02fGcz97f1IQmyIZ9HCW+0mxl6EHOKIvq0AhGwt5YEU30h9oNCjsNzVea+k7qtL3 xIfzL/nGQYpuwcXCQ9lTUE4l7IQR/4pmmZjmTECAwQJWJI4F01ncGpexB01J7xyEz7QW EhwEbvWfFfyQZ9ScN+EgQXA9dMOgqqd45dej05Kx27MJo5X/v6EayouFggntj5hNA0so lBa7fC6L0wdo0N43uF7jwuYQmx2wCOsfO395RKXY9n4Gs6Uk5CyY64IY0fKsEWBUse/x 9BKPlair3mWLAvIV0gVg/iXWZBscnJDIAjyCNWZ6FloIUFnIM8VczjUBtMB4a7YZGAgy i19A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726539769; x=1727144569; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ymm14DvclZR6EwNa1VR+Y/QCzcjsiiSSfxF2e1CPRak=; b=ujPpnpssmzvH/uuXWi4al0K7eZrXcgPk6H4+OUqY8HslxO+cBVeRuzc/wywc/+1gLm pkOybmbAgp/Pd4Sk83NMXTuD9sBG9MO9ku4OnI1CIa1AzQMCwFKrBTyMlSgPNWPN+72O zPXOdCUlIn3LgGYoUWFSxtZ+NPthtx0r1Ad0FsLTf0wLQAEC8MRcC9X6ci55tE1LD+uK v3xBzHza7qdIM2KnUcoLbT0Mp+dxIVMmGjA+QhNtM+oqU0fmlBEKWm8/bLapjeL9ptzp ihHo3Wja+DnYHJ+DnXJOqV2ZJ2kAxkzH5X7a95ZQuW0Urh1RBHMqMOzuZhDy+O85XEc0 kwdw== X-Forwarded-Encrypted: i=1; AJvYcCWuSstOLjKYAThiTdeP9M2XcNzHhXzDZkdI4B/ApFGBKsjKO+porAuHbkUj2LBBa8dxR1imBvOzTA==@vger.kernel.org X-Gm-Message-State: AOJu0Yyph9Ai9377oZVtwmhk59L2ga5mtgbfSatxvStYmx41uSceHDXI U2OQI4/58LB1GKt5TpWlC8ur7N8w2ybkEjboG1td3WFLUx3fMx7mUhiNke5AAOo= X-Google-Smtp-Source: AGHT+IF63k/bT2LAMPZwhQTEmuWk2DDFQQHQivUkBrnWMayxrI+PuPeBEDVu4AeofwYY5kFrT16u+A== X-Received: by 2002:a05:600c:1987:b0:42c:b4f1:f281 with SMTP id 5b1f17b1804b1-42cdb58f2bbmr122075475e9.34.1726539769534; Mon, 16 Sep 2024 19:22:49 -0700 (PDT) Received: from [127.0.0.1] ([185.44.53.103]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-378e71f0600sm8471045f8f.9.2024.09.16.19.22.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Sep 2024 19:22:48 -0700 (PDT) From: Jens Axboe To: Dan Carpenter Cc: Pavel Begunkov , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org In-Reply-To: <6f6cb630-079f-4fdf-bf95-1082e0a3fc6e@stanley.mountain> References: <6f6cb630-079f-4fdf-bf95-1082e0a3fc6e@stanley.mountain> Subject: Re: [PATCH] io_uring: clean up a type in io_uring_register_get_file() Message-Id: <172653976849.74656.8223840794211444474.b4-ty@kernel.dk> Date: Mon, 16 Sep 2024 20:22:48 -0600 Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.1 On Mon, 16 Sep 2024 17:07:10 +0300, Dan Carpenter wrote: > Originally "fd" was unsigned int but it was changed to int when we pulled > this code into a separate function in commit 0b6d253e084a > ("io_uring/register: provide helper to get io_ring_ctx from 'fd'"). This > doesn't really cause a runtime problem because the call to > array_index_nospec() will clamp negative fds to 0 and nothing else uses > the negative values. > > [...] Applied, thanks! [1/1] io_uring: clean up a type in io_uring_register_get_file() (no commit info) Best regards, -- Jens Axboe