From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 748DA1E9072 for ; Wed, 30 Oct 2024 13:09:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730293792; cv=none; b=ZppmGuGLV+PKfk/50ncvOA660xQs7pibwfBYPUf/OiwUcqOvED1m8PyY3AkrjRXa5AId6Qncwc//QFvl5jd7VXCtjbpk7emzqqWTynI2Tfj1JwjxK/cGaeT7k01M2Yr1dYK6awNkkUhTl5QCZ93WrEMwaArt4TWeFFuSc2DFcpw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730293792; c=relaxed/simple; bh=E5OwLTPy54ufFGgeBpt5ox7GUyM51fdd+bAxUQchzFg=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=XnFgGNPxnSYFMMW7H+I9Q4CicW1ORO7Spsllsw1Qj/MNpof/CjgG+apCXtSll/k85gJAZH116oNEHh4GjFmvFv3Iu456dv4St8wJghhqnmzQhSUjDPK7dJKmLoITX8JmQOhNuuLmSu5cDiXGwEOD9SXjS7gdwOs11SHtNVDRZ1k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=hwMwd1xA; arc=none smtp.client-ip=209.85.166.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="hwMwd1xA" Received: by mail-io1-f42.google.com with SMTP id ca18e2360f4ac-8377fd760b0so247091739f.2 for ; Wed, 30 Oct 2024 06:09:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1730293788; x=1730898588; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LAS1y4kZ27f1rr18cg6s15oqwDD8HYKBoo6u8v38O4g=; b=hwMwd1xAdjjzsa2bcepYVHhaKoyG6zIXaC0BNxmuQX1BrBMYhPWZk19ohypDhvh6d3 UGwW02p7ozyNSltuYAp2RVuu85PVPWiax5vrjs1opSRgisRwdk78haM5usLhXhQZQVrz 1AzIIG+u7TAcCOLYR4ZdeeC7H+SR/O2tU6Lt556LvBVKZwrJSvS/X6fex6Y3GFb9MXpM EQb9b6vsOnuGlHW2Lzyp7i2OEvVUdbyEJpW63gq6T63AVaHrFr2hukCaKwnwS24UKGl3 3W7n/CJZpbowROnIgg0asRJ4qfzzLQKuG85FTpd1WcVBtic+5R4tYQBoOQCT5b5xsjZW nJVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730293788; x=1730898588; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LAS1y4kZ27f1rr18cg6s15oqwDD8HYKBoo6u8v38O4g=; b=PZbTdJJW/ZhJm56wCCHuiadMVCk5htVHdaA8YPZQZ5CANTLGWF/aaDJzhmfDNLXanf ZWEei2bSJJhwFuCVIriEtApj7fBGtfKUhCTpiBWTtNoW7wiJNar8GFTmYHcmk9feI131 SVEuL4Y1czEt9P6pk7Hs1ksXJv0ysgH8EMthVTZH0jTKVSJMc9VLAsKCiJwoX35F6N7A Ays/1AC6Yd+oiiwogbvUtK1VEwPLRuIUX5tDm171Yxb5tG5ifhoBeYiLreJSHIRlH+jZ KuI+tqg5Yl+AdAmh2DVsQaKcUeqsMHUZOrZ4+P981j/gMrDDa+x+3p8c5EB90CMw1VDo OwyA== X-Forwarded-Encrypted: i=1; AJvYcCWrkXLopqkDpinFNGvqmutO36LeXQp650fu2an1v7Swf1mBAtjfh9y/NnfeyR9mmRrMnwBK/r8h3A==@vger.kernel.org X-Gm-Message-State: AOJu0Yw5iyGtmIQ/Yqh1WujhIWfn/8AaBhStI/V+PShjc/POitpk2e0G LjPJvG8wBBYHW2dEUsK8lmMFi0OUYm4n61yqFCIVjXFJW5zfGIbvlHfdGQjkdUYnAt3NU3yh4cd h X-Google-Smtp-Source: AGHT+IENNDyNNZGII1nL/NaaQ0kx9gLki/JevI1ijapsM9JD9CCx62rACXRjzrtMV0m6Zp+z0JciFA== X-Received: by 2002:a05:6602:1656:b0:834:d7b6:4fea with SMTP id ca18e2360f4ac-83b1c3e9fcemr1284626039f.6.1730293788122; Wed, 30 Oct 2024 06:09:48 -0700 (PDT) Received: from [127.0.0.1] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4dc72751298sm2872855173.91.2024.10.30.06.09.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Oct 2024 06:09:47 -0700 (PDT) From: Jens Axboe To: Dan Carpenter Cc: Pavel Begunkov , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org In-Reply-To: <70879312-810a-49ce-aba3-fdf7f902a477@stanley.mountain> References: <70879312-810a-49ce-aba3-fdf7f902a477@stanley.mountain> Subject: Re: [PATCH next] io_uring/rsrc: fix error code in io_clone_buffers() Message-Id: <173029378724.7840.5463253318064416297.b4-ty@kernel.dk> Date: Wed, 30 Oct 2024 07:09:47 -0600 Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.2 On Wed, 30 Oct 2024 12:55:06 +0300, Dan Carpenter wrote: > Return -ENOMEM if the allocation fails. Don't return success. > > Applied, thanks! [1/1] io_uring/rsrc: fix error code in io_clone_buffers() commit: 0f576012ae2ff08009ce91e2294832e2b88aba06 Best regards, -- Jens Axboe