From: Jens Axboe <[email protected]>
To: [email protected], Pavel Begunkov <[email protected]>
Subject: Re: [PATCH 1/1] io_uring: fix corner case forgetting to vunmap
Date: Wed, 27 Nov 2024 15:05:26 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <477e75a3907a2fe83249e49c0a92cd480b2c60e0.1732569842.git.asml.silence@gmail.com>
On Mon, 25 Nov 2024 23:10:31 +0000, Pavel Begunkov wrote:
> io_pages_unmap() is a bit tricky in trying to figure whether the pages
> were previously vmap'ed or not. In particular If there is juts one page
> it belives there is no need to vunmap. Paired io_pages_map(), however,
> could've failed io_mem_alloc_compound() and attempted to
> io_mem_alloc_single(), which does vmap, and that leads to unpaired vmap.
>
> The solution is to fail if io_mem_alloc_compound() can't allocate a
> single page. That's the easiest way to deal with it, and those two
> functions are getting removed soon, so no need to overcomplicate it.
>
> [...]
Applied, thanks!
[1/1] io_uring: fix corner case forgetting to vunmap
commit: 43eef70e7e2ac74e7767731dd806720c7fb5e010
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2024-11-27 22:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 23:10 [PATCH 1/1] io_uring: fix corner case forgetting to vunmap Pavel Begunkov
2024-11-27 22:05 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173274512676.579859.5626643774955881812.b4-ty@kernel.dk \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox