From: Jens Axboe <[email protected]>
To: [email protected], Pavel Begunkov <[email protected]>
Cc: Will <[email protected]>
Subject: Re: [PATCH 1/1] io_uring: check if iowq is kileed before queuing
Date: Thu, 19 Dec 2024 13:32:52 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <63312b4a2c2bb67ad67b857d17a300e1d3b078e8.1734637909.git.asml.silence@gmail.com>
On Thu, 19 Dec 2024 19:52:58 +0000, Pavel Begunkov wrote:
> task works can be executed after the task has gone through io_uring
> termination, whether it's the final task_work run or the fallback path.
> In this case, task work will fined ->io_wq being already killed and
> null'ed, which is a problem if it then tries to forward the request to
> io_queue_iowq(). Make io_queue_iowq() to fail requests in this case.
>
> Note that it also checks PF_KTHREAD, because the user can first close
> a DEFER_TASKRUN ring and shortly after kill the task, in which case
> ->iowq check would race.
>
> [...]
Applied, thanks!
[1/1] io_uring: check if iowq is kileed before queuing
commit: dbd2ca9367eb19bc5e269b8c58b0b1514ada9156
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2024-12-19 20:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-19 19:52 [PATCH 1/1] io_uring: check if iowq is kileed before queuing Pavel Begunkov
2024-12-19 20:32 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173464037242.998783.16891287792615272558.b4-ty@kernel.dk \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox