From: Jens Axboe <[email protected]>
To: [email protected], Pavel Begunkov <[email protected]>
Cc: chase xd <[email protected]>
Subject: Re: [PATCH v2 1/1] io_uring/rw: fix downgraded mshot read
Date: Sat, 28 Dec 2024 13:14:00 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <c5c8c4a50a882fd581257b81bf52eee260ac29fd.1735407848.git.asml.silence@gmail.com>
On Sat, 28 Dec 2024 17:44:52 +0000, Pavel Begunkov wrote:
> The iowq path can downgrade a multishot request to the oneshot mode,
> however io_read_mshot() doesn't handle that and would still post
> multiple CQEs. That's not allowed, because io_req_post_cqe() requires
> stricter context requirements.
>
> The described can only happen with pollable files that don't support
> FMODE_NOWAIT, which is an odd combination, so if even allowed it should
> be fairly rare.
>
> [...]
Applied, thanks!
[1/1] io_uring/rw: fix downgraded mshot read
commit: 38fc96a58ce40257aec79b32e9b310c86907c63c
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2024-12-28 20:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-28 17:44 [PATCH v2 1/1] io_uring/rw: fix downgraded mshot read Pavel Begunkov
2024-12-28 20:14 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173541684006.337376.14250384523524172856.b4-ty@kernel.dk \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox