From: Jens Axboe <[email protected]>
To: [email protected], Pavel Begunkov <[email protected]>
Cc: lizetao <[email protected]>,
Bui Quang Minh <[email protected]>
Subject: Re: [PATCH 1/1] io_uring: don't touch sqd->thread off tw add
Date: Fri, 10 Jan 2025 14:00:59 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <1cbbe72cf32c45a8fee96026463024cd8564a7d7.1736541357.git.asml.silence@gmail.com>
On Fri, 10 Jan 2025 20:36:45 +0000, Pavel Begunkov wrote:
> With IORING_SETUP_SQPOLL all requests are created by the SQPOLL task,
> which means that req->task should always match sqd->thread. Since
> accesses to sqd->thread should be separately protected, use req->task
> in io_req_normal_work_add() instead.
>
> Note, in the eyes of io_req_normal_work_add(), the SQPOLL task struct
> is always pinned and alive, and sqd->thread can either be the task or
> NULL. It's only problematic if the compiler decides to reload the value
> after the null check, which is not so likely.
>
> [...]
Applied, thanks!
[1/1] io_uring: don't touch sqd->thread off tw add
commit: bd2703b42decebdcddf76e277ba76b4c4a142d73
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2025-01-10 21:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-10 20:36 [PATCH 1/1] io_uring: don't touch sqd->thread off tw add Pavel Begunkov
2025-01-10 20:40 ` Pavel Begunkov
2025-01-10 21:00 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173654285960.870565.9353820235118737791.b4-ty@kernel.dk \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox