* RE: [PATCH] io_uring: expose read/write attribute capability
2024-12-05 6:21 ` [PATCH] io_uring: expose read/write attribute capability Anuj Gupta
@ 2024-12-05 6:54 ` lizetao
2025-01-02 21:22 ` Martin K. Petersen
2025-01-11 0:12 ` Jens Axboe
2 siblings, 0 replies; 6+ messages in thread
From: lizetao @ 2024-12-05 6:54 UTC (permalink / raw)
To: Anuj Gupta, [email protected], [email protected],
[email protected]
Cc: [email protected], [email protected]
> -----Original Message-----
> From: Anuj Gupta <[email protected]>
> Sent: Thursday, December 5, 2024 2:21 PM
> To: [email protected]; [email protected]; [email protected]
> Cc: [email protected]; [email protected]; Anuj Gupta
> <[email protected]>
> Subject: [PATCH] io_uring: expose read/write attribute capability
>
> After commit 9a213d3b80c0, we can pass additional attributes along with
> read/write. However, userspace doesn't know that. Add a new feature flag
> IORING_FEAT_RW_ATTR, to notify the userspace that the kernel has this
> ability.
>
> Signed-off-by: Anuj Gupta <[email protected]>
> ---
> include/uapi/linux/io_uring.h | 1 +
> io_uring/io_uring.c | 3 ++-
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/io_uring.h b/include/uapi/linux/io_uring.h
> index 38f0d6b10eaf..e11c82638527 100644
> --- a/include/uapi/linux/io_uring.h
> +++ b/include/uapi/linux/io_uring.h
> @@ -577,6 +577,7 @@ struct io_uring_params {
> #define IORING_FEAT_REG_REG_RING (1U << 13)
> #define IORING_FEAT_RECVSEND_BUNDLE (1U << 14)
> #define IORING_FEAT_MIN_TIMEOUT (1U << 15)
> +#define IORING_FEAT_RW_ATTR (1U << 16)
>
> /*
> * io_uring_register(2) opcodes and arguments diff --git
> a/io_uring/io_uring.c b/io_uring/io_uring.c index
> a8cbe674e5d6..a895de54eb3e 100644
> --- a/io_uring/io_uring.c
> +++ b/io_uring/io_uring.c
> @@ -3710,7 +3710,8 @@ static __cold int io_uring_create(unsigned entries,
> struct io_uring_params *p,
> IORING_FEAT_EXT_ARG |
> IORING_FEAT_NATIVE_WORKERS |
> IORING_FEAT_RSRC_TAGS | IORING_FEAT_CQE_SKIP
> |
> IORING_FEAT_LINKED_FILE |
> IORING_FEAT_REG_REG_RING |
> - IORING_FEAT_RECVSEND_BUNDLE |
> IORING_FEAT_MIN_TIMEOUT;
> + IORING_FEAT_RECVSEND_BUNDLE |
> IORING_FEAT_MIN_TIMEOUT |
> + IORING_FEAT_RW_ATTR;
>
> if (copy_to_user(params, p, sizeof(*p))) {
> ret = -EFAULT;
> --
> 2.25.1
>
Reviewed-by: Li Zetao <[email protected]>
--
Li Zetao
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] io_uring: expose read/write attribute capability
2024-12-05 6:21 ` [PATCH] io_uring: expose read/write attribute capability Anuj Gupta
2024-12-05 6:54 ` lizetao
@ 2025-01-02 21:22 ` Martin K. Petersen
2025-01-10 22:21 ` Martin K. Petersen
2025-01-11 0:12 ` Jens Axboe
2 siblings, 1 reply; 6+ messages in thread
From: Martin K. Petersen @ 2025-01-02 21:22 UTC (permalink / raw)
To: Anuj Gupta; +Cc: axboe, asml.silence, anuj1072538, io-uring, vishak.g
> After commit 9a213d3b80c0, we can pass additional attributes along
> with read/write. However, userspace doesn't know that. Add a new
> feature flag IORING_FEAT_RW_ATTR, to notify the userspace that the
> kernel has this ability.
Reviewed-by: Martin K. Petersen <[email protected]>
Tested-by: Martin K. Petersen <[email protected]>
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] io_uring: expose read/write attribute capability
2025-01-02 21:22 ` Martin K. Petersen
@ 2025-01-10 22:21 ` Martin K. Petersen
2025-01-10 22:32 ` Pavel Begunkov
0 siblings, 1 reply; 6+ messages in thread
From: Martin K. Petersen @ 2025-01-10 22:21 UTC (permalink / raw)
To: axboe, asml.silence; +Cc: Anuj Gupta, anuj1072538, io-uring, vishak.g
>> After commit 9a213d3b80c0, we can pass additional attributes along
>> with read/write. However, userspace doesn't know that. Add a new
>> feature flag IORING_FEAT_RW_ATTR, to notify the userspace that the
>> kernel has this ability.
>
> Reviewed-by: Martin K. Petersen <[email protected]>
> Tested-by: Martin K. Petersen <[email protected]>
Jens/Pavel: Ping? Would be good to get this into 6.14.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] io_uring: expose read/write attribute capability
2025-01-10 22:21 ` Martin K. Petersen
@ 2025-01-10 22:32 ` Pavel Begunkov
0 siblings, 0 replies; 6+ messages in thread
From: Pavel Begunkov @ 2025-01-10 22:32 UTC (permalink / raw)
To: Martin K. Petersen, axboe; +Cc: Anuj Gupta, anuj1072538, io-uring, vishak.g
On 1/10/25 22:21, Martin K. Petersen wrote:
>
>>> After commit 9a213d3b80c0, we can pass additional attributes along
>>> with read/write. However, userspace doesn't know that. Add a new
>>> feature flag IORING_FEAT_RW_ATTR, to notify the userspace that the
>>> kernel has this ability.
>>
>> Reviewed-by: Martin K. Petersen <[email protected]>
>> Tested-by: Martin K. Petersen <[email protected]>
>
> Jens/Pavel: Ping? Would be good to get this into 6.14.
Thanks for the reminder, it got lost in the list.
Reviewed-by: Pavel Begunkov <[email protected]>
--
Pavel Begunkov
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] io_uring: expose read/write attribute capability
2024-12-05 6:21 ` [PATCH] io_uring: expose read/write attribute capability Anuj Gupta
2024-12-05 6:54 ` lizetao
2025-01-02 21:22 ` Martin K. Petersen
@ 2025-01-11 0:12 ` Jens Axboe
2 siblings, 0 replies; 6+ messages in thread
From: Jens Axboe @ 2025-01-11 0:12 UTC (permalink / raw)
To: asml.silence, anuj1072538, Anuj Gupta; +Cc: io-uring, vishak.g
On Thu, 05 Dec 2024 11:51:09 +0530, Anuj Gupta wrote:
> After commit 9a213d3b80c0, we can pass additional attributes along with
> read/write. However, userspace doesn't know that. Add a new feature flag
> IORING_FEAT_RW_ATTR, to notify the userspace that the kernel has this
> ability.
>
>
Applied, thanks!
[1/1] io_uring: expose read/write attribute capability
commit: 94d57442e56d2ad2ca20d096040b8ae6f216a921
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 6+ messages in thread