From: Jens Axboe <[email protected]>
To: Pavel Begunkov <[email protected]>, Jann Horn <[email protected]>
Cc: [email protected], [email protected]
Subject: Re: [PATCH v2] io_uring/rsrc: Simplify buffer cloning by locking both rings
Date: Thu, 16 Jan 2025 07:13:34 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On Wed, 15 Jan 2025 21:26:03 +0100, Jann Horn wrote:
> The locking in the buffer cloning code is somewhat complex because it goes
> back and forth between locking the source ring and the destination ring.
>
> Make it easier to reason about by locking both rings at the same time.
> To avoid ABBA deadlocks, lock the rings in ascending kernel address order,
> just like in lock_two_nondirectories().
>
> [...]
Applied, thanks!
[1/1] io_uring/rsrc: Simplify buffer cloning by locking both rings
commit: 8865af703c087b8bcc2fdd04b6a93d3cc0fb0e9f
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2025-01-16 14:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 20:26 [PATCH v2] io_uring/rsrc: Simplify buffer cloning by locking both rings Jann Horn
2025-01-15 20:31 ` Jens Axboe
2025-01-16 14:13 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173703681418.10865.3728594442935840848.b4-ty@kernel.dk \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox