From: Jens Axboe <[email protected]>
To: Pavel Begunkov <[email protected]>, Jann Horn <[email protected]>
Cc: [email protected], [email protected]
Subject: Re: [PATCH] io_uring/uring_cmd: add missing READ_ONCE() on shared memory read
Date: Wed, 22 Jan 2025 12:38:49 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On Tue, 21 Jan 2025 17:09:59 +0100, Jann Horn wrote:
> cmd->sqe seems to point to shared memory here; so values should only be
> read from it with READ_ONCE(). To ensure that the compiler won't generate
> code that assumes the value in memory will stay constant, add a
> READ_ONCE().
> The callees io_uring_cmd_getsockopt() and io_uring_cmd_setsockopt() already
> do this correctly.
>
> [...]
Applied, thanks!
[1/1] io_uring/uring_cmd: add missing READ_ONCE() on shared memory read
commit: 0963dba3dc006b454c54fd019bbbdb931e7a7c70
Best regards,
--
Jens Axboe
next prev parent reply other threads:[~2025-01-22 19:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-21 16:09 [PATCH] io_uring/uring_cmd: add missing READ_ONCE() on shared memory read Jann Horn
2025-01-22 19:38 ` Jens Axboe [this message]
2025-01-23 0:18 ` Jens Axboe
2025-01-23 14:44 ` Jann Horn
2025-01-23 15:11 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173757472950.267317.14676213787840454554.b4-ty@kernel.dk \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox