* [PATCH] io_uring/rsrc: remove unused constants
@ 2025-02-19 3:34 Caleb Sander Mateos
2025-02-19 6:25 ` lizetao
2025-02-19 15:06 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Caleb Sander Mateos @ 2025-02-19 3:34 UTC (permalink / raw)
To: Jens Axboe, Pavel Begunkov; +Cc: Caleb Sander Mateos, io-uring, linux-kernel
IO_NODE_ALLOC_CACHE_MAX has been unused since commit fbbb8e991d86
("io_uring/rsrc: get rid of io_rsrc_node allocation cache") removed the
rsrc_node_cache.
IO_RSRC_TAG_TABLE_SHIFT and IO_RSRC_TAG_TABLE_MASK have been unused
since commit 7029acd8a950 ("io_uring/rsrc: get rid of per-ring
io_rsrc_node list") removed the separate tag table for registered nodes.
Signed-off-by: Caleb Sander Mateos <[email protected]>
---
io_uring/rsrc.h | 6 ------
1 file changed, 6 deletions(-)
diff --git a/io_uring/rsrc.h b/io_uring/rsrc.h
index a6d883c62b22..0297daf02ac7 100644
--- a/io_uring/rsrc.h
+++ b/io_uring/rsrc.h
@@ -2,16 +2,10 @@
#ifndef IOU_RSRC_H
#define IOU_RSRC_H
#include <linux/lockdep.h>
-#define IO_NODE_ALLOC_CACHE_MAX 32
-
-#define IO_RSRC_TAG_TABLE_SHIFT (PAGE_SHIFT - 3)
-#define IO_RSRC_TAG_TABLE_MAX (1U << IO_RSRC_TAG_TABLE_SHIFT)
-#define IO_RSRC_TAG_TABLE_MASK (IO_RSRC_TAG_TABLE_MAX - 1)
-
enum {
IORING_RSRC_FILE = 0,
IORING_RSRC_BUFFER = 1,
};
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH] io_uring/rsrc: remove unused constants
2025-02-19 3:34 [PATCH] io_uring/rsrc: remove unused constants Caleb Sander Mateos
@ 2025-02-19 6:25 ` lizetao
2025-02-19 15:06 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: lizetao @ 2025-02-19 6:25 UTC (permalink / raw)
To: Caleb Sander Mateos
Cc: Jens Axboe, Pavel Begunkov, [email protected],
[email protected]
Hi,
> -----Original Message-----
> From: Caleb Sander Mateos <[email protected]>
> Sent: Wednesday, February 19, 2025 11:35 AM
> To: Jens Axboe <[email protected]>; Pavel Begunkov <[email protected]>
> Cc: Caleb Sander Mateos <[email protected]>; io-
> [email protected]; [email protected]
> Subject: [PATCH] io_uring/rsrc: remove unused constants
>
> IO_NODE_ALLOC_CACHE_MAX has been unused since commit fbbb8e991d86
> ("io_uring/rsrc: get rid of io_rsrc_node allocation cache") removed the
> rsrc_node_cache.
>
> IO_RSRC_TAG_TABLE_SHIFT and IO_RSRC_TAG_TABLE_MASK have been
> unused since commit 7029acd8a950 ("io_uring/rsrc: get rid of per-ring
> io_rsrc_node list") removed the separate tag table for registered nodes.
>
> Signed-off-by: Caleb Sander Mateos <[email protected]>
> ---
> io_uring/rsrc.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/io_uring/rsrc.h b/io_uring/rsrc.h index
> a6d883c62b22..0297daf02ac7 100644
> --- a/io_uring/rsrc.h
> +++ b/io_uring/rsrc.h
> @@ -2,16 +2,10 @@
> #ifndef IOU_RSRC_H
> #define IOU_RSRC_H
>
> #include <linux/lockdep.h>
>
> -#define IO_NODE_ALLOC_CACHE_MAX 32
> -
> -#define IO_RSRC_TAG_TABLE_SHIFT (PAGE_SHIFT - 3)
> -#define IO_RSRC_TAG_TABLE_MAX (1U << IO_RSRC_TAG_TABLE_SHIFT)
> -#define IO_RSRC_TAG_TABLE_MASK (IO_RSRC_TAG_TABLE_MAX - 1)
> -
> enum {
> IORING_RSRC_FILE = 0,
> IORING_RSRC_BUFFER = 1,
> };
>
> --
> 2.45.2
>
Reviewed-by: Li Zetao <[email protected]>
---
Li Zetao
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] io_uring/rsrc: remove unused constants
2025-02-19 3:34 [PATCH] io_uring/rsrc: remove unused constants Caleb Sander Mateos
2025-02-19 6:25 ` lizetao
@ 2025-02-19 15:06 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2025-02-19 15:06 UTC (permalink / raw)
To: Pavel Begunkov, Caleb Sander Mateos; +Cc: io-uring, linux-kernel
On Tue, 18 Feb 2025 20:34:43 -0700, Caleb Sander Mateos wrote:
> IO_NODE_ALLOC_CACHE_MAX has been unused since commit fbbb8e991d86
> ("io_uring/rsrc: get rid of io_rsrc_node allocation cache") removed the
> rsrc_node_cache.
>
> IO_RSRC_TAG_TABLE_SHIFT and IO_RSRC_TAG_TABLE_MASK have been unused
> since commit 7029acd8a950 ("io_uring/rsrc: get rid of per-ring
> io_rsrc_node list") removed the separate tag table for registered nodes.
>
> [...]
Applied, thanks!
[1/1] io_uring/rsrc: remove unused constants
commit: fb3331f53e3cb1f1505f918f4f33bb0a3a231e4f
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-02-19 15:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-19 3:34 [PATCH] io_uring/rsrc: remove unused constants Caleb Sander Mateos
2025-02-19 6:25 ` lizetao
2025-02-19 15:06 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox