* [PATCH 1/1] io_uring: add req flag invariant build assertion
@ 2025-03-31 7:54 Pavel Begunkov
2025-03-31 13:07 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Pavel Begunkov @ 2025-03-31 7:54 UTC (permalink / raw)
To: io-uring; +Cc: asml.silence
We're caching some of file related request flags in a tricky way, put
a build check to make sure flags don't get reshuffled.
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
---
io_uring/io_uring.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c
index cb17deffd6ca..6df996d01ccf 100644
--- a/io_uring/io_uring.c
+++ b/io_uring/io_uring.c
@@ -1643,6 +1643,8 @@ io_req_flags_t io_file_get_flags(struct file *file)
{
io_req_flags_t res = 0;
+ BUILD_BUG_ON(REQ_F_ISREG_BIT != REQ_F_SUPPORT_NOWAIT_BIT + 1);
+
if (S_ISREG(file_inode(file)->i_mode))
res |= REQ_F_ISREG;
if ((file->f_flags & O_NONBLOCK) || (file->f_mode & FMODE_NOWAIT))
--
2.48.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] io_uring: add req flag invariant build assertion
2025-03-31 7:54 [PATCH 1/1] io_uring: add req flag invariant build assertion Pavel Begunkov
@ 2025-03-31 13:07 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2025-03-31 13:07 UTC (permalink / raw)
To: io-uring, Pavel Begunkov
On Mon, 31 Mar 2025 08:54:00 +0100, Pavel Begunkov wrote:
> We're caching some of file related request flags in a tricky way, put
> a build check to make sure flags don't get reshuffled.
>
>
Applied, thanks!
[1/1] io_uring: add req flag invariant build assertion
commit: 697b2876ac037545ba2761e2ffe9a5c2af6424e6
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-31 13:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-31 7:54 [PATCH 1/1] io_uring: add req flag invariant build assertion Pavel Begunkov
2025-03-31 13:07 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox