From: Jens Axboe <axboe@kernel.dk>
To: io-uring@vger.kernel.org, Pavel Begunkov <asml.silence@gmail.com>
Subject: Re: [PATCH 1/1] io_uring/zcrx: put refill data into separate cache line
Date: Wed, 09 Apr 2025 07:45:01 -0600 [thread overview]
Message-ID: <174420630174.200173.3793649620674054176.b4-ty@kernel.dk> (raw)
In-Reply-To: <6d1f598e27d623c07fc49d6baee13089a9b1216c.1743848241.git.asml.silence@gmail.com>
On Sat, 05 Apr 2025 11:17:49 +0100, Pavel Begunkov wrote:
> Refill queue lock and other bits are only used from the allocation path
> on the rx softirq side, but it shares the cache line with other fields
> like ctx that are used also in the "syscall" path, which causes cache
> bouncing when softirq runs on a different CPU.
>
> Separate them into different cache lines. The first one now contains
> constant fields used by both contextx, followed by a line responsible
> for refill queue data.
>
> [...]
Applied, thanks!
[1/1] io_uring/zcrx: put refill data into separate cache line
(no commit info)
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2025-04-09 13:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-05 10:17 [PATCH 1/1] io_uring/zcrx: put refill data into separate cache line Pavel Begunkov
2025-04-09 13:45 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174420630174.200173.3793649620674054176.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox