From: Jens Axboe <axboe@kernel.dk>
To: io-uring@vger.kernel.org, Pavel Begunkov <asml.silence@gmail.com>
Cc: "David Wei" <dw@davidwei.uk>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Mina Almasry" <almasrymina@google.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH io_uring-6.15] io_uring/zcrx: fix late dma unmap for a dead dev
Date: Fri, 18 Apr 2025 08:01:25 -0600 [thread overview]
Message-ID: <174498488589.689807.7439507318071758979.b4-ty@kernel.dk> (raw)
In-Reply-To: <ef9b7db249b14f6e0b570a1bb77ff177389f881c.1744965853.git.asml.silence@gmail.com>
On Fri, 18 Apr 2025 13:02:27 +0100, Pavel Begunkov wrote:
> There is a problem with page pools not dma-unmapping immediately
> when the device is going down, and delaying it until the page pool is
> destroyed, which is not allowed (see links). That just got fixed for
> normal page pools, and we need to address memory providers as well.
>
> Unmap pages in the memory provider uninstall callback, and protect it
> with a new lock. There is also a gap between a dma mapping is created
> and the mp is installed, so if the device is killed in between,
> io_uring would be hodling dma mapping to a dead device with no one to
> call ->uninstall. Move it to page pool init and rely on ->is_mapped to
> make sure it's only done once.
>
> [...]
Applied, thanks!
[1/1] io_uring/zcrx: fix late dma unmap for a dead dev
commit: f12ecf5e1c5eca48b8652e893afcdb730384a6aa
Best regards,
--
Jens Axboe
next prev parent reply other threads:[~2025-04-18 14:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 12:02 [PATCH io_uring-6.15] io_uring/zcrx: fix late dma unmap for a dead dev Pavel Begunkov
2025-04-18 14:01 ` Jens Axboe [this message]
2025-04-22 8:57 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174498488589.689807.7439507318071758979.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=almasrymina@google.com \
--cc=asml.silence@gmail.com \
--cc=dw@davidwei.uk \
--cc=io-uring@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox