From: Jens Axboe <axboe@kernel.dk>
To: io-uring@vger.kernel.org, Pavel Begunkov <asml.silence@gmail.com>
Subject: Re: [PATCH 1/1] io_uring: remove io_preinit_req()
Date: Tue, 06 May 2025 07:48:32 -0600 [thread overview]
Message-ID: <174653931297.1466231.10187787110387595116.b4-ty@kernel.dk> (raw)
In-Reply-To: <ba5485dc913f1e275862ce88f5169d4ac4a33836.1746533807.git.asml.silence@gmail.com>
On Tue, 06 May 2025 13:31:07 +0100, Pavel Begunkov wrote:
> Apart from setting ->ctx, io_preinit_req() zeroes a bunch of fields of a
> request, from which only ->file_node is mandatory. Remove the function
> and zero the entire request on first allocation. With that, we also need
> to initialise ->ctx every time, which might be a good thing for
> performance as now we're likely overwriting the entire cache line, and
> so it can write combined and avoid RMW.
>
> [...]
Applied, thanks!
[1/1] io_uring: remove io_preinit_req()
commit: f37d2ddd9cf118f885e2e610ad0f717a7d126612
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2025-05-06 13:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 12:31 [PATCH 1/1] io_uring: remove io_preinit_req() Pavel Begunkov
2025-05-06 13:48 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174653931297.1466231.10187787110387595116.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox