public inbox for io-uring@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: io-uring@vger.kernel.org, Keith Busch <kbusch@meta.com>
Cc: superman.xpt@gmail.com, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCHv2] io_uring: consistently use rcu semantics with sqpoll thread
Date: Wed, 11 Jun 2025 15:01:23 -0600	[thread overview]
Message-ID: <174967568374.462788.11409454167475921556.b4-ty@kernel.dk> (raw)
In-Reply-To: <20250611205343.1821117-1-kbusch@meta.com>


On Wed, 11 Jun 2025 13:53:43 -0700, Keith Busch wrote:
> The sqpoll thread is dereferenced with rcu read protection in one place,
> so it needs to be annotated as an __rcu type, and should consistently
> use rcu helpers for access and assignment to make sparse happy.
> 
> Since most of the accesses occur under the sqd->lock, we can use
> rcu_dereference_protected() without declaring an rcu read section.
> Provide a simple helper to get the thread from a locked context.
> 
> [...]

Applied, thanks!

[1/1] io_uring: consistently use rcu semantics with sqpoll thread
      commit: 89f607e88c9f885187a0144d0b540fb257b912ea

Best regards,
-- 
Jens Axboe




  reply	other threads:[~2025-06-11 21:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-11 20:53 [PATCHv2] io_uring: consistently use rcu semantics with sqpoll thread Keith Busch
2025-06-11 21:01 ` Jens Axboe [this message]
2025-06-12 14:18   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=174967568374.462788.11409454167475921556.b4-ty@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=io-uring@vger.kernel.org \
    --cc=kbusch@kernel.org \
    --cc=kbusch@meta.com \
    --cc=superman.xpt@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox