From: Jens Axboe <axboe@kernel.dk>
To: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
io-uring Mailing List <io-uring@vger.kernel.org>,
Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
Bart Van Assche <bvanassche@acm.org>,
dr.xiaosa@gmail.com
Subject: Re: [PATCH liburing] liburing.h: Support C++20 module export feature
Date: Mon, 15 Sep 2025 13:06:16 -0600 [thread overview]
Message-ID: <175796317609.265653.2867794592544924823.b4-ty@kernel.dk> (raw)
In-Reply-To: <20250913162540.77167-1-ammarfaizi2@gnuweeb.org>
On Sat, 13 Sep 2025 23:25:40 +0700, Ammar Faizi wrote:
> Having "static inline" functions in liburing header file results in
> compilation errors when using the new C++20 module export feature:
>
> In file included from src/work.cpp:3:
> ./include/liburing.h:343:20: error: \
> ‘void io_uring_cq_advance(io_uring*, unsigned int)’ \
> exposes TU-local entity ‘void io_uring_smp_store_release(T*, T) [with T = unsigned int]’
> 343 | IOURINGINLINE void io_uring_cq_advance(struct io_uring *ring, unsigned nr)
> | ^~~~~~~~~~~~~~~~~~~
> In file included from ./include/liburing.h:20:
> ./include/liburing/barrier.h:42:20: note: \
> ‘void io_uring_smp_store_release(T*, T) [with T = unsigned int]’ is a \
> specialization of TU-local template \
> ‘template<class T> void io_uring_smp_store_release(T*, T)’
> 42 | static inline void io_uring_smp_store_release(T *p, T v)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> ./include/liburing/barrier.h:42:20: note: \
> ‘template<class T> void io_uring_smp_store_release(T*, T)’ declared with internal linkage
>
> [...]
Applied, thanks!
[1/1] liburing.h: Support C++20 module export feature
commit: 5503c2b545709e1cf8484670aa7088a827f4818d
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2025-09-15 19:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-13 16:25 [PATCH liburing] liburing.h: Support C++20 module export feature Ammar Faizi
2025-09-15 19:06 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175796317609.265653.2867794592544924823.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=alviro.iskandar@gnuweeb.org \
--cc=ammarfaizi2@gnuweeb.org \
--cc=bvanassche@acm.org \
--cc=dr.xiaosa@gmail.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox