From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 696EF2D3720 for ; Tue, 23 Sep 2025 06:16:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758608168; cv=none; b=RrjQJgCp1gthoOKkdBgvOPqc48lrA7pHrCwFM6Mkwu6uBa7vtU9NTGZc1aiNkOLrQlBASS99NXw5jDUn5GefeuCiQD518PtoDQ14YkjW9WlAG9wQzx97c/bEkwXA5CJILPuG2JTrki3Cdax7lRJGckeMhmErltIYeTX9vyTxAlY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758608168; c=relaxed/simple; bh=hD3OyQ5pf25nKvDX44eZPgzgzaCMLNBDyqZl+ZVGAdQ=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=hI8TJqUZsUINinJwPtkkgAKfXPIbTQwkdOvGDQ+d+0nenAIm5His+V9ttpZPPtwVEpcOsgvByadEoYhIV8rxWV3YaamJ9xnGXLj3us0bfTHSPcM2cr08Fs+aurffwt9iOJ6cqQl/FH2ffZxIHIGP1x+9Ndk0hUBLD65qH+ED8NM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=pQNuksgV; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="pQNuksgV" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-77d94c6562fso5209110b3a.2 for ; Mon, 22 Sep 2025 23:16:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1758608165; x=1759212965; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SqB+MBmWbGWhXPKkNDOEdyh6sNxW8IJTQY+jeJPWHj8=; b=pQNuksgV6XfvkPUrE68/laDXSvCRDVjQznG/iTdXDBXW3S7Xrj/2y16BfBMTSQx1pn bpKUEMbiebfFjhRo5j8VGy9vzfiJshHArWmV5/ESISGfTYDQu9ZSMz7NKg3vn9DSAuRE 0WjV7EVgCvMeRT0CSla5eBAGrhEh9/StXm0+T9r3IIJJ9dIoffMduRGBLyeqULEuVtal WP0zUUABx6UeTAuxU5eMEZj9IxsWvrJrSDUKr93k3fogPGcopdMDaaTFozwE2ZrjBKmD 9Yhq6ac61RWCylPbdyS/iRwhq+0mIKQfCzj0B2De49Oa0pe2dMVMr/6UUgVjnKW4cfOh fDxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758608165; x=1759212965; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SqB+MBmWbGWhXPKkNDOEdyh6sNxW8IJTQY+jeJPWHj8=; b=S9heAIGzsAArg4TvqCPo1JNu2XwYlF0cF7ahCYsyLFTwgA7ER3N91V4fkiBbH+Tluu TBRdi5ULc33yGYq0ZAkP62gqrauZkShX2a5uqJTtVBQ9Xns1iTdSnT/wxszbUVarOXuW nnJe4jORZDkTviSNFHdgNokbBHahFKkgm/OCAIwbM0ggTTtGMVxJij7VjI9JVWI3MlQn LqXBAGaZji8cLzzMdOyA0dbK05ggNAkSPN1ti/X0d2Aac4XlqVoo9JI4rA/m5rNdln2D IHJ/pZCVaFwbvmVVjCrNqcjxGTgddXEkwEe8PD2jA/wbG5azGo+uGXvERuGYnzTkdu9p A/7g== X-Forwarded-Encrypted: i=1; AJvYcCXAwyx1abhHINUzJaPeFEquLNxnSA+/REgC2LHyXQxrw6hjvkiuGsbPEcBT6WkY8LCVHx1coIx6JQ==@vger.kernel.org X-Gm-Message-State: AOJu0YwgioF3IZhVnFg7C68jFC8HOPLKnAAvycEykeVX/qwCMDWkpLXW LgH9Ny/SX4zqslS5gIcQ3xTsgH3vuDkg0dXmcxbtno/1cNKj9tN42j6VmCSv3TtxY2Q= X-Gm-Gg: ASbGnctWfyRg1/ueprKCzOlfBjd+xZeW98/pf1eLzbhnQeaCM40+wXAbHFADnrfrKUy dwD3PGYWnd0TMn6bCpP7GJlTRaW3HZNBiaLYRscKBmgcByaP9OdK7rQCtbzD7Ai+haxR5WSKGjo HESg9i6PmUsVV7+OoA+JpwHsLYV8gmjSyz928IJHwThM4HziYq6WWyUI4ACa14GYVcJMFSKx0WJ J0YijGuJcrfaivt5Pc5Kv+PPydr4ER8x9o5t6z3UAlK/XQjv55UF+cskWcVHcrlilH7B6jZL4H8 tZOheXtKFRLSh+53owRymQULhFr2N8L8UJ2Cc7WyS81zHwOwA7zIvZR3O1MIPqXLFVoOr+70LZ3 rvT7F9jaWCF5radS58Q== X-Google-Smtp-Source: AGHT+IHuGnb8PBfUENdPuGyGvLbbla7V1vgnkQ+GzlyH7sUUWYMzzRFQlMWMmSJwfIFZawKhZl2ScQ== X-Received: by 2002:a05:6a00:4fd4:b0:77f:169d:7f62 with SMTP id d2e1a72fcca58-77f538ea09bmr2180704b3a.14.1758608165503; Mon, 22 Sep 2025 23:16:05 -0700 (PDT) Received: from [127.0.0.1] ([178.208.16.192]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-77cfc24739fsm14285188b3a.28.2025.09.22.23.16.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Sep 2025 23:16:03 -0700 (PDT) From: Jens Axboe To: Ming Lei , Chris Mason , Josef Bacik , David Sterba , Miklos Szeredi , Caleb Sander Mateos Cc: Keith Busch , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org In-Reply-To: <20250922170234.2269956-1-csander@purestorage.com> References: <20250922170234.2269956-1-csander@purestorage.com> Subject: Re: [PATCH] io_uring/cmd: drop unused res2 param from io_uring_cmd_done() Message-Id: <175860816137.146699.7149828855280856823.b4-ty@kernel.dk> Date: Tue, 23 Sep 2025 00:16:01 -0600 Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3-dev-2ce6c On Mon, 22 Sep 2025 11:02:31 -0600, Caleb Sander Mateos wrote: > Commit 79525b51acc1 ("io_uring: fix nvme's 32b cqes on mixed cq") split > out a separate io_uring_cmd_done32() helper for ->uring_cmd() > implementations that return 32-byte CQEs. The res2 value passed to > io_uring_cmd_done() is now unused because __io_uring_cmd_done() ignores > it when is_cqe32 is passed as false. So drop the parameter from > io_uring_cmd_done() to simplify the callers and clarify that it's not > possible to return an extra value beyond the 32-bit CQE result. > > [...] Applied, thanks! [1/1] io_uring/cmd: drop unused res2 param from io_uring_cmd_done() commit: ef9f603fd3d4b7937f2cdbce40e47df0a54b2a55 Best regards, -- Jens Axboe