From: Jens Axboe <axboe@kernel.dk>
To: csander@purestorage.com, io-uring@vger.kernel.org,
Alok Tiwari <alok.a.tiwari@oracle.com>
Cc: alok.a.tiwarilinux@gmail.com
Subject: Re: [PATCH v2] io_uring: fix incorrect unlikely() usage in io_waitid_prep()
Date: Mon, 20 Oct 2025 09:22:50 -0600 [thread overview]
Message-ID: <176097377066.18128.4545746576618587852.b4-ty@kernel.dk> (raw)
In-Reply-To: <20251018193300.1517312-1-alok.a.tiwari@oracle.com>
On Sat, 18 Oct 2025 12:32:54 -0700, Alok Tiwari wrote:
> The negation operator incorrectly places outside the unlikely() macro:
>
> if (!unlikely(iwa))
>
> This inverted the compiler branch prediction hint, marking the NULL
> case as likely instead of unlikely. The intent is to indicate that
> allocation failures are rare, consistent with common kernel patterns.
>
> [...]
Applied, thanks!
[1/1] io_uring: fix incorrect unlikely() usage in io_waitid_prep()
commit: 4ec703ec0c384a2199808c4eb2e9037236285a8d
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2025-10-20 15:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-18 19:32 [PATCH v2] io_uring: fix incorrect unlikely() usage in io_waitid_prep() Alok Tiwari
2025-10-19 16:27 ` Caleb Sander Mateos
2025-10-20 15:23 ` Jens Axboe
2025-10-20 15:00 ` Gabriel Krisman Bertazi
2025-10-20 15:22 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176097377066.18128.4545746576618587852.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=alok.a.tiwari@oracle.com \
--cc=alok.a.tiwarilinux@gmail.com \
--cc=csander@purestorage.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox