From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f171.google.com (mail-il1-f171.google.com [209.85.166.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5190F33F380 for ; Thu, 20 Nov 2025 14:52:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763650371; cv=none; b=WOncqs323/KVsBPhg6jYXEz2Hi/WVGuWHCimyrAqfeGx7/sUsx4+ZD4j3SfdcHAHnz1Ctk/cpDaHULna8DOddP56X4WW1xZCwStZWsbeDvb5D99Sxr3N90bs8cz3oFGVpXzK9wc3qbkhjcGieeDxNXsJNhmA9n99yd3FYkEX+eA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763650371; c=relaxed/simple; bh=fJNbQYu7PoiJLsEPpjUYNqAPI6k2geFEJacIKnsv5a4=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=TXEbB1eUVH8L+Wqj3NukzdLW62EdATs19OO06AS62AA7UzWjrBUAwca31HpTr8qEllkXGun+KRTffmPkcgcE/3ElBggV2ebDTP2vsvad/oXCRyUXDN/AIZmFPOizXnNV6w+jcChXuRoF26+mckDfLcYpa+hV6Z6edCSo+JVsMdA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=Nlop4bDN; arc=none smtp.client-ip=209.85.166.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="Nlop4bDN" Received: by mail-il1-f171.google.com with SMTP id e9e14a558f8ab-43346da8817so5269625ab.0 for ; Thu, 20 Nov 2025 06:52:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1763650367; x=1764255167; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mIp1emodWmrQX+c6TjoXmEBGWcecINECr9nK+dGHBUw=; b=Nlop4bDNIOkjuo0pMhzaqc0ODrEsmRo7XtLqwhp00uyFASxw+sbIvvfDKg63/0WNIr Irgw7i1L5c7f3KspyZuRfY76O51HffIuodvQy5ZIcDN4No7WwIxUOGZ9dpes/M6K+nsd SNLzENdMcdkRpJUmuFjuM9BMlGaR61DPmsUMatu7aVJzbpi7Z/RO6GbliOgOscpBha8S DnzFtV5phPRpPEJgf98WlMFKyzL6CdLykV3ZnkTgBAq3ZRb9M24771+6fglXYKmcEHuj JwzMwrRMP1iOEu/PZF6XSo/nxjqLzdvmfaif9TGvKGR4YXIy2m1LIpokuAZvSHGS7C+s olCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763650367; x=1764255167; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=mIp1emodWmrQX+c6TjoXmEBGWcecINECr9nK+dGHBUw=; b=U+K3jRLos+1yX354Eq7SlFsHYWjRk+qOzXBlxUmKkP3Kxe6gLu0aa83kAftrM0q/vS 4MWgO9bvxfo6tcyAIrIzc8GSEnON7jiQRGXBn1UvncOqm9+PzOe4xl2TM5VumlrXuexk Ob9PMw7TCeMS/fzyd05kX2OYyifGaN8wrW7VmYNvwqW4KQQMf+E7F2eggvgotaWihKdd 9GDtTgqp1IwCTCMmU6CT/ZYnRs+UKPjlOIuXzBFgnAfahUeYKYq2cKw3nHZqvVxTiAda iQCyfYBLVDTDo56FfWe1MFxU1bKMWg2hDt3vFbmzCS1zy6Ft7N5fwFwZvVI8YKuqmXt+ w6zA== X-Forwarded-Encrypted: i=1; AJvYcCV11oz9ib2YPjwpSVAmpN5DUFq7GuDFQnNeanehdI2SoxUbUmaNqbayt4sAtRP30a71g7yyLHSfyQ==@vger.kernel.org X-Gm-Message-State: AOJu0YxO+ZBAeE+ZXokP2hxec5zual85ahUbB+/VdP4+O+HamIchC1LD +GxJPZ0TXAzaxk9IOnlpGaXt9uG/hjcroFvqw3RXR5K6ajxPMIrV7Wd6iuklN7VOteQ= X-Gm-Gg: ASbGncs/vw2OPsOZA5OTGPMGK/OfqTJcboyIg8eWgR1tyF6JC3GM93+fDGKD1fJcmBQ igV1iAhY4xVEC1ZJ5+I0PzRg7oVTZzBGrbAcHVsHF+7VOh8Lk8vNbnAZ3zBj3szvns9PFUKgdFS BcC3KZ5totFiDugRrIy5uq63BE0L1fSChv+hy8Rmkd9vhdXMJpsJbm4RRgRiTolUdEvuWk7Pjc2 P2IEEIEr4XR033uhLL/zQTRjtFLt8xKGbvdUB1W7Kv6xL314/qrwSs2YsZaubRvufDrlpE95zi4 xGxsBsoOfAiCoiqjuDIOnveB9YPO5faLBnwkATjdIXrtzF+Wu+K5f9o6Octc5URWmh4s+lceZVP b9EGn3/kb29HT66VZsDI5BGMefNWVHbV0jBHAZ8+UqW483rpQeV070DRRc87pU5s5HE3X27V54N Fwjg== X-Google-Smtp-Source: AGHT+IEmRlVKCe07qbgo1t2w3uFpBKsqx62crTftDC+8sZ0oUBIrcGL53VTRakva//fmnWvcfQrQww== X-Received: by 2002:a05:6e02:1c01:b0:433:1d5a:5157 with SMTP id e9e14a558f8ab-435aa88e822mr21434775ab.6.1763650367018; Thu, 20 Nov 2025 06:52:47 -0800 (PST) Received: from [127.0.0.1] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-5b954b207d7sm1008611173.33.2025.11.20.06.52.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Nov 2025 06:52:46 -0800 (PST) From: Jens Axboe To: linux-kernel@vger.kernel.org, david.laight.linux@gmail.com Cc: Alan Stern , Alexander Viro , Alexei Starovoitov , Andi Shyti , Andreas Dilger , Andrew Lunn , Andrew Morton , Andrii Nakryiko , Andy Shevchenko , Ard Biesheuvel , Arnaldo Carvalho de Melo , Bjorn Helgaas , Borislav Petkov , Christian Brauner , =?utf-8?q?Christian_K=C3=B6nig?= , Christoph Hellwig , Daniel Borkmann , Dan Williams , Dave Hansen , Dave Jiang , David Ahern , Davidlohr Bueso , "David S. Miller" , Dennis Zhou , Eric Dumazet , Greg Kroah-Hartman , Herbert Xu , Ingo Molnar , Jakub Kicinski , Jakub Sitnicki , "James E.J. Bottomley" , Jarkko Sakkinen , "Jason A. Donenfeld" , Jiri Slaby , Johannes Weiner , John Allen , Jonathan Cameron , Juergen Gross , Kees Cook , KP Singh , Linus Walleij , "Martin K. Petersen" , "Matthew Wilcox (Oracle)" , Mika Westerberg , Mike Rapoport , Miklos Szeredi , Namhyung Kim , Neal Cardwell , nic_swsd@realtek.com, OGAWA Hirofumi , Olivia Mackall , Paolo Abeni , Paolo Bonzini , Peter Huewe , Peter Zijlstra , "Rafael J. Wysocki" , Sean Christopherson , Srinivas Kandagatla , Stefano Stabellini , Steven Rostedt , Tejun Heo , Theodore Ts'o , Thomas Gleixner , Tom Lendacky , Willem de Bruijn , x86@kernel.org, Yury Norov , amd-gfx@lists.freedesktop.org, bpf@vger.kernel.org, cgroups@vger.kernel.org, dri-devel@lists.freedesktop.org, io-uring@vger.kernel.org, kvm@vger.kernel.org, linux-acpi@vger.kernel.org, linux-block@vger.kernel.org, linux-crypto@vger.kernel.org, linux-cxl@vger.kernel.org, linux-efi@vger.kernel.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-integrity@vger.kernel.org, linux-mm@kvack.org, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-scsi@vger.kernel.org, linux-serial@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-usb@vger.kernel.org, mptcp@lists.linux.dev, netdev@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, David Hildenbrand In-Reply-To: <20251119224140.8616-1-david.laight.linux@gmail.com> References: <20251119224140.8616-1-david.laight.linux@gmail.com> Subject: Re: (subset) [PATCH 00/44] Change a lot of min_t() that might mask high bits Message-Id: <176365036384.566630.2992984118137417732.b4-ty@kernel.dk> Date: Thu, 20 Nov 2025 07:52:43 -0700 Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3 On Wed, 19 Nov 2025 22:40:56 +0000, david.laight.linux@gmail.com wrote: > It in not uncommon for code to use min_t(uint, a, b) when one of a or b > is 64bit and can have a value that is larger than 2^32; > This is particularly prevelant with: > uint_var = min_t(uint, uint_var, uint64_expression); > > Casts to u8 and u16 are very likely to discard significant bits. > > [...] Applied, thanks! [12/44] block: use min() instead of min_t() commit: 9420e720ad192c53c8d2803c5a2313b2d586adbd Best regards, -- Jens Axboe