From: Jens Axboe <axboe@kernel.dk>
To: Jakub Kicinski <kuba@kernel.org>
Cc: asml.silence@gmail.com, io-uring@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH iouring] io_uring/zcrx: don't set rx_page_size when not requested
Date: Fri, 27 Feb 2026 12:33:09 -0700 [thread overview]
Message-ID: <177222078925.1175759.14027962125344899947.b4-ty@kernel.dk> (raw)
In-Reply-To: <20260227170745.2845550-1-kuba@kernel.org>
On Fri, 27 Feb 2026 09:07:45 -0800, Jakub Kicinski wrote:
> The rx_buf_len parameter was recently added to the Rx zero-copy
> implementation. The expectation is that when not set system will
> maintain previous behavior and use the default buffer size (PAGE_SIZE).
>
> This works correctly at the iouring level, but we don't preserve
> the same "zero means default" semantics when registering the memory
> provider on the netdev. mp_param.rx_page_size is unconditionally
> set to PAGE_SIZE. This causes __net_mp_open_rxq() to check for
> QCFG_RX_PAGE_SIZE support in the driver, and return -EOPNOTSUPP
> for drivers that don't advertise it -- even though the user never
> asked for large buffers.
>
> [...]
Applied, thanks!
[1/1] io_uring/zcrx: don't set rx_page_size when not requested
commit: 3d17d76d1ffb139a7492317b196ee03c8eabc9dc
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2026-02-27 19:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 17:07 [PATCH iouring] io_uring/zcrx: don't set rx_page_size when not requested Jakub Kicinski
2026-02-27 19:23 ` Pavel Begunkov
2026-02-27 19:33 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177222078925.1175759.14027962125344899947.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox