From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f54.google.com (mail-oo1-f54.google.com [209.85.161.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 373321E00B4 for ; Fri, 27 Feb 2026 19:33:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772220793; cv=none; b=BMZIScDTttn3MW8jGDw50jFFA3oj4fPBPrn62/4xsu0pz/+r/r9nt6/kog9uT6Kdvbax8Msy6XWPOXEck+PAdmdFb8Ta2tfksXP4/b7ZbuI/4U6dFaoZ4wsnUCzFnDx6PIcNkjGplNJoER77hCat0XfrrtF8mY8fx7sgGBeNhKQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772220793; c=relaxed/simple; bh=S4WdxBoSFmfJsmtzwU9/+jBMzeHEFzoLSWqHQ/oztJI=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=Y9OfeGg1ImawPnTo5rkB7uroDkGLgtpyFPFJvK9zlDRgjrFlR8i6CXG40y8cHYEVvgMSPBsdmqVhbokJ9Y3Om4VxHHdCbmH4nGsQvR7erTY+qWBYlPSGK0yhoZTHkTrmYBOMSsTRbk+BiRC8wYlx0lA/q8FDVSgSpgBDN72bk+s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=1X1OldCe; arc=none smtp.client-ip=209.85.161.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="1X1OldCe" Received: by mail-oo1-f54.google.com with SMTP id 006d021491bc7-66307e10d1dso1651500eaf.0 for ; Fri, 27 Feb 2026 11:33:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1772220790; x=1772825590; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=I72P8NX2zIzLVHc9Smmzo8h4IvPgg0/X8dsbl8+CW3I=; b=1X1OldCex4/JPZOpIy/JkuJLRFosKdFsiDcLrZ0aBLZaSALtPtUtGSlRwAAF97Gjt5 pf7zgo1epiZRJhVW06C09Oa+0dERandX2x6rI9z2G94YovIx7J1diU2ZFQeIdTkTx17j wQiy5tKKtHKPqcXJT6P/uzE+4yRvKzIbZdH4nvZmsqmxrGCZR+GembW3+wcRFbAFYc9B 4gsbZhU3g0+fPmG2VVd33DlOQ/95Sriij35OF3w3AGZ1xhjRHW4F0ZiJ2pq7D/Axg1aU sXrig4BeuUYe+JB47HkQq+NK2kFI86xWlKW2xYdhUujiPdnCdxMVk5I0OkOTs6gQsCfW R5Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772220790; x=1772825590; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=I72P8NX2zIzLVHc9Smmzo8h4IvPgg0/X8dsbl8+CW3I=; b=End7XPvGBCwLlfSWdCFJCd3RXpdd6RnnqSJIjLsYuYUDmG9iKR73sDbGRH2+S9Hbjp qE2oWc9VxXajLZ+sx5EfZqgYo1vDgmwHeyQH8LWGZNSYxHU2TVGyH4hx6DjEl2hr8QDJ nq3wGw3jWxwv/hLVEuQsicZVeXy70NLqTP6ReKswmTTispqVPEPQQguYUWIYjT81L6UC cLg3HnsJ5XhebPup+GPnxdMh97/+sJ4M5e+dodnSHAIOdyrmHDgLNAIWCBIIqSLTSrgo PvePuEabBH0Dq7/FoRX3lLjl72lr9mOjf5pJzZPrmbwxgYGO5z0GCTXu3vUqr2J7waDw CMJg== X-Forwarded-Encrypted: i=1; AJvYcCXTlroh8wWjNCzmtqpKapZOUl3mhnNzUjxnE7efD+oAHnCOnfPCiZ9UslJo7Q43x1fwgDSP28b3NQ==@vger.kernel.org X-Gm-Message-State: AOJu0Yw41mncslZ2TV7GJ53X+0d/rIhI60Yd+iKr1qqgVWsmoJqMYqCv AcHr/cCsT2HZNg1puANrk5fj9gE61VfF1Zrhp85traLAokjSqQc4+CawogFqBkG8DFc= X-Gm-Gg: ATEYQzx++ltZP8U+1xFGPZnPiQTntye22Vt5cPUW+AvHQC6h++l2Y9/byZHtNnLYrNG LyjF2aZ3usiz6neEFyWtQxLpgghyG2fAnltsrkxYJmSiBZbr3VrwqsIX3k8ol/2i3b7aT7+g/dG DtjarZFk+So2of9yy/0epZW91HjjV18/QiXCRC1Wd7FjHy3VgqT8rmUTdNfHayYr4PjQrsl0FhF x9FLt1XmP095fVrXkQ8zktIlvvgF+ClwOJd9dqftSHmrKkQPeTUI9lc2p/vO01utuXJAT1ZW3AN y2H8OAfkCBo7pX+GIFRclzAup+DN1tB2q/nTW8M6d2Iq2d3ZoQUTSJ3bnApf0nmnOgtQoWwGf5R E7y58ytHTExdQKTOWNsrKBivwtSflNzhgBkcK66nSSR4+3rHym6N1BCYpznBVldp9ShpcRFEZCx GlwOXov/FhJTGIrdw5zkmySSDh4SFKImSq40+xcsKjirvK5A2M6K4ec0oEOxrTJTbUjGz8sov/j BRJ X-Received: by 2002:a05:6820:2226:b0:679:f6f1:8063 with SMTP id 006d021491bc7-679faf96001mr2489233eaf.67.1772220790033; Fri, 27 Feb 2026 11:33:10 -0800 (PST) Received: from [127.0.0.1] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-4160d20ec7fsm5478145fac.11.2026.02.27.11.33.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 11:33:09 -0800 (PST) From: Jens Axboe To: Jakub Kicinski Cc: asml.silence@gmail.com, io-uring@vger.kernel.org, netdev@vger.kernel.org In-Reply-To: <20260227170745.2845550-1-kuba@kernel.org> References: <20260227170745.2845550-1-kuba@kernel.org> Subject: Re: [PATCH iouring] io_uring/zcrx: don't set rx_page_size when not requested Message-Id: <177222078925.1175759.14027962125344899947.b4-ty@kernel.dk> Date: Fri, 27 Feb 2026 12:33:09 -0700 Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3 On Fri, 27 Feb 2026 09:07:45 -0800, Jakub Kicinski wrote: > The rx_buf_len parameter was recently added to the Rx zero-copy > implementation. The expectation is that when not set system will > maintain previous behavior and use the default buffer size (PAGE_SIZE). > > This works correctly at the iouring level, but we don't preserve > the same "zero means default" semantics when registering the memory > provider on the netdev. mp_param.rx_page_size is unconditionally > set to PAGE_SIZE. This causes __net_mp_open_rxq() to check for > QCFG_RX_PAGE_SIZE support in the driver, and return -EOPNOTSUPP > for drivers that don't advertise it -- even though the user never > asked for large buffers. > > [...] Applied, thanks! [1/1] io_uring/zcrx: don't set rx_page_size when not requested commit: 3d17d76d1ffb139a7492317b196ee03c8eabc9dc Best regards, -- Jens Axboe