From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50826C43334 for ; Wed, 20 Jul 2022 12:48:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240436AbiGTMsN (ORCPT ); Wed, 20 Jul 2022 08:48:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231571AbiGTMsM (ORCPT ); Wed, 20 Jul 2022 08:48:12 -0400 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABDD42A272 for ; Wed, 20 Jul 2022 05:48:11 -0700 (PDT) Received: by mail-pj1-x102c.google.com with SMTP id gq7so1515977pjb.1 for ; Wed, 20 Jul 2022 05:48:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=gGzhbksNlmAjolVQXQdc9eTCDYUNBeJ75ClnIeGoBhQ=; b=p4DVtuHsUlq3ow05vMOkgjy2v8TGkBw9yNnqN0k3Aez87VPlF/SrkPj5HMP+WMIMpa 1+LFW6tYsXVIOkCzmONzXA0EAFKIUfZBghG1PRzbdUdJgZdSfZM0lrAnItaIv60JDGgj xJEQcJzCh/SPy5GP65S0ddQkj8BvR1BXbgNJCb0dW7q2UKWomROZPbtuHxe3H7k2Z4/L XuGRDG4muhkTbtCGccalZ+DbKsgLVdEcN42mdmMOEJhkUVp+aEBPcGM/qXl2D9gOm0jq ZHvp+oeLZ/yvVXWXqo2yIZyWXYZJ2yoJR5AKPD5C8fev28ydJjva7QdpjqDzOKSXCAAY AjqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=gGzhbksNlmAjolVQXQdc9eTCDYUNBeJ75ClnIeGoBhQ=; b=IiAMk+7lHIiU3MViu75WDV0RmZce4oDLobOES5p70yCXkiuKdghf/9NEnq4P/oMXR+ Hjd1lTBiAFYMILPtKv/eHvCW24QsCUL7QxEog9NWcySCy8MsE1WphKnNiDRnTFumh6qa AzzQmL0RBYnHC8QTjq5sZND9KW1+eaIwyq0Pv88NWVRSLiuQi/++mKwAO9cRqkCgYF9P OoVgO18z4GvXKVKii1NKRDnO58HB+4pgI4li4w4cKAn0QR6bZMicH8BQr/kZ+acJtCwy gobKjP4Jed2tcMJvatH6y99KIAqDh225SOUkDkt8aTE2Vnfro/xnEFPoE3Fv5cNWSs/Y zxCQ== X-Gm-Message-State: AJIora/4JD4ePuhDoql7bA9y+eXj/zkRV8I2fAqnSyFYeI00MgVNT6X8 03zwNKqU59YkXG54th1cOiAQuA== X-Google-Smtp-Source: AGRyM1sWwt7u1rTQL3JPhU9/TDBVwmyvsCTLPJg5D9wKXKP4XmGv+Ftymq6kH5fEnfwVfjO7Yh9vkw== X-Received: by 2002:a17:902:eb8e:b0:16c:29dc:f1f3 with SMTP id q14-20020a170902eb8e00b0016c29dcf1f3mr38949744plg.22.1658321291126; Wed, 20 Jul 2022 05:48:11 -0700 (PDT) Received: from [192.168.1.100] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id u14-20020a654c0e000000b0040d0a57be02sm11875401pgq.31.2022.07.20.05.48.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Jul 2022 05:48:10 -0700 (PDT) Message-ID: <17dba691-2a2b-4b20-40c3-ec77282179b0@kernel.dk> Date: Wed, 20 Jul 2022 06:48:09 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v5.10 1/1] io_uring: Use original task for req identity in io_identity_cow() Content-Language: en-US To: Lee Jones Cc: stable@vger.kernel.org, Pavel Begunkov , Alexander Viro , io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <20220719115251.441526-1-lee@kernel.org> From: Jens Axboe In-Reply-To: <20220719115251.441526-1-lee@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 7/19/22 5:52 AM, Lee Jones wrote: > This issue is conceptually identical to the one fixed in 29f077d07051 > ("io_uring: always use original task when preparing req identity"), so > rather than reinvent the wheel, I'm shamelessly quoting the commit > message from that patch - thanks Jens: > > "If the ring is setup with IORING_SETUP_IOPOLL and we have more than > one task doing submissions on a ring, we can up in a situation where > we assign the context from the current task rather than the request > originator. > > Always use req->task rather than assume it's the same as current. > > No upstream patch exists for this issue, as only older kernels with > the non-native workers have this problem." Greg, can you pick this one up for 5.10-stable? Thanks! -- Jens Axboe