[syzbot] [io-uring?] WARNING in io_pin_pages

[syzbot] [io-uring?] WARNING in io_pin_pages

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit:    ae58226b89ac Add linux-next specific files for 20241118
git tree:       linux-next
console+strace: https://syzkaller.appspot.com/x/log.txt?x=14a67378580000
kernel config:  https://syzkaller.appspot.com/x/.config?x=45719eec4c74e6ba
dashboard link: https://syzkaller.appspot.com/bug?extid=2159cbb522b02847c053
compiler:       Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=137beac0580000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=177beac0580000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/fd3d650cd6b6/disk-ae58226b.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/89a0fb674130/vmlinux-ae58226b.xz
kernel image: https://storage.googleapis.com/syzbot-assets/92120e1c6775/bzImage-ae58226b.xz

The issue was bisected to:

commit 68685fa20edc5307fc893a06473c19661c236f29
Author: Pavel Begunkov <asml.silence@gmail.com>
Date:   Fri Nov 15 16:54:38 2024 +0000

    io_uring: fortify io_pin_pages with a warning

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=17b73bf7980000
final oops:     https://syzkaller.appspot.com/x/report.txt?x=14773bf7980000
console output: https://syzkaller.appspot.com/x/log.txt?x=10773bf7980000

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+2159cbb522b02847c053@syzkaller.appspotmail.com
Fixes: 68685fa20edc ("io_uring: fortify io_pin_pages with a warning")

------------[ cut here ]------------
WARNING: CPU: 0 PID: 5834 at io_uring/memmap.c:144 io_pin_pages+0x149/0x180 io_uring/memmap.c:144
Modules linked in:
CPU: 0 UID: 0 PID: 5834 Comm: syz-executor825 Not tainted 6.12.0-next-20241118-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/30/2024
RIP: 0010:io_pin_pages+0x149/0x180 io_uring/memmap.c:144
Code: 63 fd 4c 89 f8 5b 41 5c 41 5e 41 5f 5d c3 cc cc cc cc e8 da c1 e3 fc 90 0f 0b 90 49 c7 c7 ea ff ff ff eb de e8 c8 c1 e3 fc 90 <0f> 0b 90 49 c7 c7 b5 ff ff ff eb cc 44 89 f1 80 e1 07 80 c1 03 38
RSP: 0018:ffffc90003d17c10 EFLAGS: 00010293
RAX: ffffffff84bbb6e8 RBX: fff0000000000091 RCX: ffff88802c6d5a00
RDX: 0000000000000000 RSI: fff0000000000091 RDI: 000000007fffffff
RBP: 000ffffffffffff0 R08: ffffffff84bbb5ee R09: 1ffff110041538c0
R10: dffffc0000000000 R11: ffffed10041538c1 R12: ffffffffffff0000
R13: ffffffffffff0000 R14: ffffc90003d17c80 R15: 1ffff110068d2920
FS:  0000555568d4e380(0000) GS:ffff8880b8600000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000055ee7661e0d8 CR3: 0000000075cb2000 CR4: 00000000003526f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <TASK>
 __io_uaddr_map+0xfb/0x2d0 io_uring/memmap.c:183
 io_rings_map io_uring/io_uring.c:2611 [inline]
 io_allocate_scq_urings+0x1c0/0x650 io_uring/io_uring.c:3470
 io_uring_create+0x5b5/0xc00 io_uring/io_uring.c:3692
 io_uring_setup io_uring/io_uring.c:3781 [inline]
 __do_sys_io_uring_setup io_uring/io_uring.c:3808 [inline]
 __se_sys_io_uring_setup+0x2ba/0x330 io_uring/io_uring.c:3802
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7feda57a15a9
Code: 48 83 c4 28 c3 e8 37 17 00 00 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fff8a663b18 EFLAGS: 00000246 ORIG_RAX: 00000000000001a9
RAX: ffffffffffffffda RBX: 0000000000002c0c RCX: 00007feda57a15a9
RDX: ffffffffffffffb8 RSI: 0000000020000400 RDI: 0000000000002c0c
RBP: 00007feda5814610 R08: 0000000000000000 R09: 0000000000000000
R10: 00000000000000e8 R11: 0000000000000246 R12: 0000000000000001
R13: 00007fff8a663cf8 R14: 0000000000000001 R15: 0000000000000001
 </TASK>


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
For information about bisection process see: https://goo.gl/tpsmEJ#bisection

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

Re: [syzbot] [io-uring?] WARNING in io_pin_pages

[Pavel Begunkov]

On 11/22/24 10:51, syzbot wrote:
> Hello,
> 
> syzbot found the following issue on:
> 
> HEAD commit:    ae58226b89ac Add linux-next specific files for 20241118
> git tree:       linux-next
> console+strace: https://syzkaller.appspot.com/x/log.txt?x=14a67378580000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=45719eec4c74e6ba
> dashboard link: https://syzkaller.appspot.com/bug?extid=2159cbb522b02847c053
> compiler:       Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=137beac0580000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=177beac0580000
> 
> Downloadable assets:
> disk image: https://storage.googleapis.com/syzbot-assets/fd3d650cd6b6/disk-ae58226b.raw.xz
> vmlinux: https://storage.googleapis.com/syzbot-assets/89a0fb674130/vmlinux-ae58226b.xz
> kernel image: https://storage.googleapis.com/syzbot-assets/92120e1c6775/bzImage-ae58226b.xz
> 
> The issue was bisected to:
> 
> commit 68685fa20edc5307fc893a06473c19661c236f29
> Author: Pavel Begunkov <asml.silence@gmail.com>
> Date:   Fri Nov 15 16:54:38 2024 +0000
> 
>      io_uring: fortify io_pin_pages with a warning

Seems I wasn't too paranoid. I'll send a fix

-- 
Pavel Begunkov

Re: [syzbot] [io-uring?] WARNING in io_pin_pages

[Pavel Begunkov]

On 11/22/24 15:02, Pavel Begunkov wrote:
> On 11/22/24 10:51, syzbot wrote:
>> Hello,
>>
>> syzbot found the following issue on:
>>
>> HEAD commit:    ae58226b89ac Add linux-next specific files for 20241118
>> git tree:       linux-next
>> console+strace: https://syzkaller.appspot.com/x/log.txt?x=14a67378580000
>> kernel config:  https://syzkaller.appspot.com/x/.config?x=45719eec4c74e6ba
>> dashboard link: https://syzkaller.appspot.com/bug?extid=2159cbb522b02847c053
>> compiler:       Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
>> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=137beac0580000
>> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=177beac0580000
>>
>> Downloadable assets:
>> disk image: https://storage.googleapis.com/syzbot-assets/fd3d650cd6b6/disk-ae58226b.raw.xz
>> vmlinux: https://storage.googleapis.com/syzbot-assets/89a0fb674130/vmlinux-ae58226b.xz
>> kernel image: https://storage.googleapis.com/syzbot-assets/92120e1c6775/bzImage-ae58226b.xz
>>
>> The issue was bisected to:
>>
>> commit 68685fa20edc5307fc893a06473c19661c236f29
>> Author: Pavel Begunkov <asml.silence@gmail.com>
>> Date:   Fri Nov 15 16:54:38 2024 +0000
>>
>>      io_uring: fortify io_pin_pages with a warning
> 
> Seems I wasn't too paranoid. I'll send a fix

#syz test: https://github.com/isilence/linux.git syz/sanitise-cqsq

-- 
Pavel Begunkov

Re: [syzbot] [io-uring?] WARNING in io_pin_pages

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
WARNING in io_pin_pages

------------[ cut here ]------------
WARNING: CPU: 0 PID: 6625 at io_uring/memmap.c:146 io_pin_pages+0x149/0x180 io_uring/memmap.c:146
Modules linked in:
CPU: 0 UID: 0 PID: 6625 Comm: syz.0.15 Not tainted 6.12.0-rc4-syzkaller-00087-g9788f6363f9a #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
RIP: 0010:io_pin_pages+0x149/0x180 io_uring/memmap.c:146
Code: 63 fd 4c 89 f8 5b 41 5c 41 5e 41 5f 5d c3 cc cc cc cc e8 0a f9 e8 fc 90 0f 0b 90 49 c7 c7 ea ff ff ff eb de e8 f8 f8 e8 fc 90 <0f> 0b 90 49 c7 c7 b5 ff ff ff eb cc 44 89 f1 80 e1 07 80 c1 03 38
RSP: 0018:ffffc90002ee7c10 EFLAGS: 00010293
RAX: ffffffff84abe228 RBX: fff0000000000091 RCX: ffff88806d4c9e00
RDX: 0000000000000000 RSI: fff0000000000091 RDI: 000000007fffffff
RBP: 000ffffffffffff0 R08: ffffffff84abe12e R09: 1ffff1100f98b260
R10: dffffc0000000000 R11: ffffed100f98b261 R12: ffffffffffff0000
R13: ffffffffffff0000 R14: ffffc90002ee7c80 R15: 1ffff110024de520
FS:  00007f3e6a15a6c0(0000) GS:ffff8880b8600000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000001b3255ffff CR3: 00000000339f8000 CR4: 00000000003526f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <TASK>
 __io_uaddr_map+0xfb/0x2d0 io_uring/memmap.c:185
 io_rings_map io_uring/io_uring.c:2632 [inline]
 io_allocate_scq_urings+0x212/0x710 io_uring/io_uring.c:3491
 io_uring_create+0x5b5/0xc00 io_uring/io_uring.c:3713
 io_uring_setup io_uring/io_uring.c:3802 [inline]
 __do_sys_io_uring_setup io_uring/io_uring.c:3829 [inline]
 __se_sys_io_uring_setup+0x2ba/0x330 io_uring/io_uring.c:3823
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f3e6937e759
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f3e6a159fc8 EFLAGS: 00000202 ORIG_RAX: 00000000000001a9
RAX: ffffffffffffffda RBX: 00007f3e69535f80 RCX: 00007f3e6937e759
RDX: 0000000000000000 RSI: 0000000020000400 RDI: 0000000000002c0c
RBP: 0000000020000400 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000202 R12: 0000000000000000
R13: 0000000000000000 R14: 0000000000002c0c R15: 0000000000000000
 </TASK>


Tested on:

commit:         9788f636 io_uring: sanitise nr_pages for SQ/CQ
git tree:       https://github.com/isilence/linux.git syz/sanitise-cqsq
console output: https://syzkaller.appspot.com/x/log.txt?x=1040e778580000
kernel config:  https://syzkaller.appspot.com/x/.config?x=f0635751ca15fb7a
dashboard link: https://syzkaller.appspot.com/bug?extid=2159cbb522b02847c053
compiler:       Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

Note: no patches were applied.

Re: [syzbot] [io-uring?] WARNING in io_pin_pages

[Pavel Begunkov]

On 11/25/24 23:34, syzbot wrote:
> Hello,
> 
> syzbot has tested the proposed patch but the reproducer is still triggering an issue:
> WARNING in io_pin_pages

Tested with the repro this time

#syz test: https://github.com/isilence/linux.git syz/sanitise-cqsq

-- 
Pavel Begunkov