public inbox for [email protected]
 help / color / mirror / Atom feed
* [PATCH] io_uring: don't setup async context for read/write fixed
@ 2020-01-14  2:27 Jens Axboe
  0 siblings, 0 replies; only message in thread
From: Jens Axboe @ 2020-01-14  2:27 UTC (permalink / raw)
  To: io-uring

We don't need it, and if we have it, then the retry handler will attempt
to copy the non-existent iovec with the inline iovec, with a segment
count that doesn't make sense.

Fixes: f67676d160c6 ("io_uring: ensure async punted read/write requests copy iovec")
Reported-by: Jonathan Lemon <[email protected]>
Signed-off-by: Jens Axboe <[email protected]>

---

diff --git a/fs/io_uring.c b/fs/io_uring.c
index 38b54051facd..8321c2f5589b 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -1786,6 +1786,9 @@ static int io_setup_async_rw(struct io_kiocb *req, ssize_t io_size,
 			     struct iovec *iovec, struct iovec *fast_iov,
 			     struct iov_iter *iter)
 {
+	if (req->opcode == IORING_OP_READ_FIXED ||
+	    req->opcode == IORING_OP_WRITE_FIXED)
+		return 0;
 	if (!req->io && io_alloc_async_ctx(req))
 		return -ENOMEM;
 
-- 
Jens Axboe


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2020-01-14  2:27 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-14  2:27 [PATCH] io_uring: don't setup async context for read/write fixed Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox