From: Pavel Begunkov <asml.silence@gmail.com>
To: io-uring@vger.kernel.org
Cc: asml.silence@gmail.com
Subject: [PATCH v2 7/7] io_uring: add lockdep warning for overflow posting
Date: Sat, 17 May 2025 13:27:43 +0100 [thread overview]
Message-ID: <19c0dd16ab837eda7e2f5276bf462f709ad23d05.1747483784.git.asml.silence@gmail.com> (raw)
In-Reply-To: <cover.1747483784.git.asml.silence@gmail.com>
io_cqring_event_overflow() must be called in the same CQ protection
section as the preceding io_get_cqe(), otherwise overflowed and normal
CQEs can get out of order. It's hard to debug check that exactly, but we
can verify that io_cqring_event_overflow() is called with the CQ locked,
which should be good enough to catch most cases of misuse.
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
---
io_uring/io_uring.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c
index 0e0b3e75010c..7f6b1fd37606 100644
--- a/io_uring/io_uring.c
+++ b/io_uring/io_uring.c
@@ -737,6 +737,8 @@ static bool io_cqring_event_overflow(struct io_ring_ctx *ctx, u64 user_data,
size_t ocq_size = sizeof(struct io_overflow_cqe);
bool is_cqe32 = (ctx->flags & IORING_SETUP_CQE32);
+ io_lockdep_assert_cq_locked(ctx);
+
if (is_cqe32)
ocq_size += sizeof(struct io_uring_cqe);
--
2.49.0
next prev parent reply other threads:[~2025-05-17 12:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-17 12:27 [PATCH v2 0/7] simplify overflow CQE handling Pavel Begunkov
2025-05-17 12:27 ` [PATCH v2 1/7] io_uring: fix overflow resched cqe reordering Pavel Begunkov
2025-05-17 12:27 ` [PATCH v2 2/7] io_uring: init overflow entry before passing to tracing Pavel Begunkov
2025-05-17 12:27 ` [PATCH v2 3/7] io_uring: open code io_req_cqe_overflow() Pavel Begunkov
2025-05-17 12:27 ` [PATCH v2 4/7] io_uring: split __io_cqring_overflow_flush() Pavel Begunkov
2025-05-17 12:27 ` [PATCH v2 5/7] io_uring: separate lock for protecting overflow list Pavel Begunkov
2025-05-17 12:27 ` [PATCH v2 6/7] io_uring: avoid GFP_ATOMIC for overflows if possible Pavel Begunkov
2025-05-17 12:27 ` Pavel Begunkov [this message]
2025-05-21 13:02 ` (subset) [PATCH v2 0/7] simplify overflow CQE handling Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19c0dd16ab837eda7e2f5276bf462f709ad23d05.1747483784.git.asml.silence@gmail.com \
--to=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox